-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved JSDoc comments for type correctness. #1161
Commits on Jul 4, 2018
-
Improved JSDoc comments for type correctness.
1. Improved JSDoc comments for better type check in VSCode with “implicitProjectConfig.checkJs": true” to enable type checking for JavaScript. 2. Introduced JSDoc type casting to solve problems with type coercion. 3. Escaped expando properties like “splitText” with [''] to resolve warning that property does not exist on object. 4. Updated JSDoc comment for VNode. Attribures property was set to type “object”. Unfortunately JSDoc types “object” and “Object” get treated as type “any” by TypeScript. To indicate a generic object you have to use this signature: Object.<string, any>. 5. Add type cast for Ctor being called with new keyword to avoid warning "Cannot use 'new' with an expression whose type lacks a call or construct signature". 6. Added type casting where type is a function, but original value could be a string as well. This tells type checker that the value can be called. 7. Added numerous type casts in diff.js to resolve type conflicts. 8. Many types had to be cast to type “any” in oder to remedy conflicts where type coercion would happen during runtime in browser, but static type checkers can’t foresee. 9. Type casting adds an extra pair of parens around the value being cast. But these are removed during minification.
Configuration menu - View commit details
-
Copy full SHA for adf8dd5 - Browse repository at this point
Copy the full SHA adf8dd5View commit details
Commits on Jul 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 26ea308 - Browse repository at this point
Copy the full SHA 26ea308View commit details
Commits on Jul 11, 2018
-
Changes to pass tsc --allowJs --checkJs
Christopher J. Brody committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for e6573fa - Browse repository at this point
Copy the full SHA e6573faView commit details -
Christopher J. Brody committed
Jul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 7d21d23 - Browse repository at this point
Copy the full SHA 7d21d23View commit details -
Christopher J. Brody committed
Jul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for b6eb3c9 - Browse repository at this point
Copy the full SHA b6eb3c9View commit details -
package.json add checkjs script
Christopher J. Brody committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 1e4140a - Browse repository at this point
Copy the full SHA 1e4140aView commit details -
Minor cleanup related to JSDoc fixes
Christopher J. Brody committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for 64e8503 - Browse repository at this point
Copy the full SHA 64e8503View commit details -
separate import for other JSDoc param items
Christopher J. Brody committedJul 11, 2018 Configuration menu - View commit details
-
Copy full SHA for e95c386 - Browse repository at this point
Copy the full SHA e95c386View commit details -
Merge pull request #1 from brodybits/cb-tsc-fix1
Experimental tsc --checkJs & cleanup fixes (for discussion)
Configuration menu - View commit details
-
Copy full SHA for d2b7141 - Browse repository at this point
Copy the full SHA d2b7141View commit details
Commits on Jul 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c0ae1d4 - Browse repository at this point
Copy the full SHA c0ae1d4View commit details -
Fix JSDoc cast in buildComponentFromVNode
using separate const
Christopher J. Brody committedJul 16, 2018 Configuration menu - View commit details
-
Copy full SHA for 05a7ddc - Browse repository at this point
Copy the full SHA 05a7ddcView commit details -
package.json use checkJs script name (camelCase)
Christopher J. Brody committedJul 16, 2018 Configuration menu - View commit details
-
Copy full SHA for aca4d72 - Browse repository at this point
Copy the full SHA aca4d72View commit details -
src/vdom/component-recycler.js remove param import
(no longer needed)
Christopher J. Brody committedJul 16, 2018 Configuration menu - View commit details
-
Copy full SHA for 7f5735e - Browse repository at this point
Copy the full SHA 7f5735eView commit details -
src/component.js move JSDoc import
Christopher J. Brody committedJul 16, 2018 Configuration menu - View commit details
-
Copy full SHA for 5ebff59 - Browse repository at this point
Copy the full SHA 5ebff59View commit details
Commits on Jul 17, 2018
-
minor cleanup of JSDoc type in internal idiff
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for dd17907 - Browse repository at this point
Copy the full SHA dd17907View commit details -
use internal consts to cleanup inline JSDoc types
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 0387927 - Browse repository at this point
Copy the full SHA 0387927View commit details -
Improved JSDoc comments for type correctness.
1. Improved JSDoc comments for better type check in VSCode with “implicitProjectConfig.checkJs": true” to enable type checking for JavaScript. 2. Introduced JSDoc type casting to solve problems with type coercion. 3. Escaped expando properties like “splitText” with [''] to resolve warning that property does not exist on object. 4. Updated JSDoc comment for VNode. Attribures property was set to type “object”. Unfortunately JSDoc types “object” and “Object” get treated as type “any” by TypeScript. To indicate a generic object you have to use this signature: Object.<string, any>. 5. Add type cast for Ctor being called with new keyword to avoid warning "Cannot use 'new' with an expression whose type lacks a call or construct signature". 6. Added type casting where type is a function, but original value could be a string as well. This tells type checker that the value can be called. 7. Added numerous type casts in diff.js to resolve type conflicts. 8. Many types had to be cast to type “any” in oder to remedy conflicts where type coercion would happen during runtime in browser, but static type checkers can’t foresee. 9. Type casting adds an extra pair of parens around the value being cast. But these are removed during minification.
Configuration menu - View commit details
-
Copy full SHA for 3a189fa - Browse repository at this point
Copy the full SHA 3a189faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed6764 - Browse repository at this point
Copy the full SHA 1ed6764View commit details -
Changes to pass tsc --allowJs --checkJs
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 37495b2 - Browse repository at this point
Copy the full SHA 37495b2View commit details -
Christopher J. Brody committed
Jul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for cc10b1c - Browse repository at this point
Copy the full SHA cc10b1cView commit details -
Christopher J. Brody committed
Jul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 6125010 - Browse repository at this point
Copy the full SHA 6125010View commit details -
Christopher J. Brody committed
Jul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 972d6b3 - Browse repository at this point
Copy the full SHA 972d6b3View commit details -
Minor cleanup related to JSDoc fixes
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 976ac4a - Browse repository at this point
Copy the full SHA 976ac4aView commit details -
separate import for other JSDoc param items
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 78ea2ef - Browse repository at this point
Copy the full SHA 78ea2efView commit details -
Fix JSDoc cast in buildComponentFromVNode
using separate const
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for bce5afa - Browse repository at this point
Copy the full SHA bce5afaView commit details -
minor cleanup of JSDoc type in internal idiff
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 5ac7548 - Browse repository at this point
Copy the full SHA 5ac7548View commit details -
use internal consts to cleanup inline JSDoc types
Christopher J. Brody committedJul 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 9f82f5b - Browse repository at this point
Copy the full SHA 9f82f5bView commit details
Commits on Jul 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0d2aea9 - Browse repository at this point
Copy the full SHA 0d2aea9View commit details -
Merge pull request #2 from brodybits/cb-tsc-fix2
More checkJs & JSDoc fixes
Configuration menu - View commit details
-
Copy full SHA for 170109b - Browse repository at this point
Copy the full SHA 170109bView commit details -
Changed text node type cast from 'any' to Node.
1. A text Node is also of type Node. So we can cast to that instead of type 'any'.
Configuration menu - View commit details
-
Copy full SHA for decf628 - Browse repository at this point
Copy the full SHA decf628View commit details
Commits on Jul 22, 2018
-
Use JSDoc types instead of property strings
Christopher J. Brody committedJul 22, 2018 Configuration menu - View commit details
-
Copy full SHA for 57a66e2 - Browse repository at this point
Copy the full SHA 57a66e2View commit details -
Fix JSDoc EventListener @typedef
Christopher J. Brody committedJul 22, 2018 Configuration menu - View commit details
-
Copy full SHA for ab2359c - Browse repository at this point
Copy the full SHA ab2359cView commit details -
src/dom/index.js move JSDoc import of Component
Christopher J. Brody committedJul 22, 2018 Configuration menu - View commit details
-
Copy full SHA for 59c4695 - Browse repository at this point
Copy the full SHA 59c4695View commit details -
Inline some consts to reduce size
Christopher J. Brody committedJul 22, 2018 Configuration menu - View commit details
-
Copy full SHA for 67e5185 - Browse repository at this point
Copy the full SHA 67e5185View commit details -
src/vdom/diff.js remove some inline JSDoc types
(not needed)
Christopher J. Brody committedJul 22, 2018 Configuration menu - View commit details
-
Copy full SHA for 36f2a27 - Browse repository at this point
Copy the full SHA 36f2a27View commit details
Commits on Jul 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fb063cf - Browse repository at this point
Copy the full SHA fb063cfView commit details -
Merge pull request #3 from brodybits/new-jsdoc-updates
jsdoc updates rebased on upstream master
Configuration menu - View commit details
-
Copy full SHA for b479244 - Browse repository at this point
Copy the full SHA b479244View commit details
Commits on Jul 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d4abe42 - Browse repository at this point
Copy the full SHA d4abe42View commit details -
Merge pull request #5 from rbiggs/revert-3-new-jsdoc-updates
Revert "jsdoc updates rebased on upstream master"
Configuration menu - View commit details
-
Copy full SHA for 8cc588d - Browse repository at this point
Copy the full SHA 8cc588dView commit details
Commits on Jul 30, 2018
-
Fixed union type for VNode children.
1. Cannot use union inside brackets. This was showing children as type `string | VNode[]` when it should have been `string[] | VNode[]`.
Configuration menu - View commit details
-
Copy full SHA for a2be058 - Browse repository at this point
Copy the full SHA a2be058View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd9743 - Browse repository at this point
Copy the full SHA bfd9743View commit details -
src/vdom/diff.js fixes to preserve original JS
Christopher J. Brody committedJul 30, 2018 Configuration menu - View commit details
-
Copy full SHA for c24eccf - Browse repository at this point
Copy the full SHA c24eccfView commit details -
src/vnode.js remove @ts-nocheck (not needed)
Christopher J. Brody committedJul 30, 2018 Configuration menu - View commit details
-
Copy full SHA for 09f9690 - Browse repository at this point
Copy the full SHA 09f9690View commit details -
Fix JSDoc return type of vdom.getNodeProps()
Co-authored-by: Robert Biggs <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c90f388 - Browse repository at this point
Copy the full SHA c90f388View commit details
Commits on Jul 31, 2018
-
Merge pull request #4 from brodybits/cb-tsc-fix3
Additional checkJS / JSDoc fixes
Configuration menu - View commit details
-
Copy full SHA for ce26426 - Browse repository at this point
Copy the full SHA ce26426View commit details