less agressive fix

preactjs · Feb 17, 2024 · 94b0563 · 94b0563
1 parent 00b71c4
commit 94b0563
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -238,6 +238,8 @@ function constructNewChildrenArray(newParentVNode, renderResult, oldChildren) {
 			) {
 				if (oldVNode._dom == newParentVNode._nextDom) {
 					newParentVNode._nextDom = getDomSibling(oldVNode);
+				} else {
+					skew++;
 				}
 				unmount(oldVNode, oldVNode, false);
 
@@ -252,7 +254,6 @@ function constructNewChildrenArray(newParentVNode, renderResult, oldChildren) {
 				// assume DOM nodes in this subtree are mounted and usable.
 				oldChildren[i] = null;
 				remainingOldChildren--;
-				skew++;
 			}
 			continue;
 		}

diff --git a/test/browser/fragments.test.js b/test/browser/fragments.test.js
@@ -1304,7 +1304,7 @@ describe('Fragment', () => {
 			'rendering from true to false'
 		);
 		expectDomLogToBe(
-			['<li>1.remove()', '<li>2.remove()'],
+			['<li>1.remove()', '<li>2.remove()', '<ol>043.appendChild(<li>4)'],
 			'rendering from true to false'
 		);