Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds shrink to fit to viewport #571

Closed
wants to merge 1 commit into from

Conversation

PeteSchuster
Copy link

What kind of change does this PR introduce?
forces iOS Safari to work like other browsers

Did you add tests for your changes?
nope

Summary
shrink-to-fit=no fixes a "feature" in iOS Safari.

more info/discussion:
h5bp/html5-boilerplate#1984
and
https://bitsofco.de/ios-safari-and-shrink-to-fit/

Does this PR introduce a breaking change?
nope

@hassanbazzi
Copy link
Member

@PeteSchuster This is something that users can simply over-ride using a template.html of their own choosing.

Although I do agree it is a somewhat sane default, usually the fix to these kinds of overflow issue is to fix the code itself.

Latest Safari has this fixed too. Feel free to re-open if you feel this is a necessary change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants