refactor: Remove Critters (perhaps temporarily) #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2adf1ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
changed the title
rschristian
added a commit
that referenced
this pull request
Jan 31, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Jan 31, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Jan 31, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Jan 31, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Feb 2, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Feb 2, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset
rschristian
added a commit
that referenced
this pull request
Oct 10, 2023
* Chore: Updating html-webpack-plugin to v4 (#1608) * chore: Correcting changeset * feat: webpack v5 (#1645) * feat: webpack-v5 * test: Update tests * docs: Updating docs to reflect changes * chore: Removing optimize-plugin local patch * refactor: Determine CSS module by filename, not directory (#1714) * refactor: Determine CSS module by filename, not directory * docs: Adding changeset * refactor: Project creation pull from templates 'main' branch * test: Updating tests * revert: Accidentally removed log message * refactor: Extracting project creation out to own package (#1708) * refactor: Extracting out project creation to own package * docs: Adding changeset * refactor: Misc edits to common deps & workspace helper scripts * test: Fixing 'create' test suite * ci: Increase minimum Node version * chore: Fix typos * docs: Update ReadMe instructions * chore: Better (and untaken) package name * docs: Update changeset * test: Update 'create' test suite & build output hashes * docs: Expounding upon changeset * refactor: Drop Preact 8 support (#1716) * refactor: Drops support for Preact v8 * docs: Adding changeset * refactor: Switch to automatic runtime JSX transform (#1725) * refactor: Switch over to automatic runtime transform for JSX * test: Removing `h` imports from test suite * docs: Adding changeset * docs: Adding readme for create-cli (#1728) * docs: Adding readme for create-cli * feat: Initial publish * fix: Correcting broken readme links * refactor: Disable hashing ssr-build's css (#1733) * refactor: Disable hashing ssr-build's css * docs: Adding changeset * test: Fix unrelated change from altered template * refactor: Remove `--preload` flag (#1737) * refactor: Removes `--preload` flag & functionality * docs: Adding changeset * docs: Updating readme for removal of preload * refactor: Separate internal concepts of config and env (#1734) * refactor: Separate internal concepts of config and env * docs: Adding changeset * refactor: prune flags (#1752) * refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset * feat: Improved errors and warnings (#1758) * refactor: Better root error handling * refactor: Switch prerender plugin to be async for error gen * refactor: Simplify & improve compilation messages * refactor: Bump Node version, remove `src` arg in build & watch, and misc housekeeping (#1753) * refactor: Drop rimraf for built-in fs.rm * refactor: Drop src argument in build & watch cmds * refactor: Extract info cmd from CLI entrypoint * refactor: Remove update-notifier * refactor: Switch from fs.promises to fs/promises * docs: Adding changeset * refactor: Move EJS into user templates (`template.html`) (#1768) * refactor: Merging EJS templates and switcing preferred template extension to .ejs * test: Fixing test suite to reflect latest changes * chore: Cleaning * docs: Updating ReadMe * docs: Adding changeset * refactor: Add error message for <% preact.(head|body)End %> * chore: Publishing cli & create-cli * Refactor: Enable Prefresh by Default (#1772) * refactor: Enables HMR via Prefresh by default * docs: Adding changeset * test: Updating tests to reflect changes to templates * refactor: Remove Critters (perhaps temporarily) (#1778) * refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset * chore: Publish v4.0.0-next.2 * refactor: Vendor Critters so that 7c811ac can be reverted (#1780) * docs: Remove CLI beta note from readme * docs: Bump minimum Node version listed in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor / Feature Removal
Did you add tests for your changes?
Modified
Summary
#1777
Unfortunately Critters hasn't been updated for Webpack v5 / HTML Webpack plugin v5. This results in an issue where the Skip Assets Plugin resolves and uses the wrong version the HTML Webpack plugin if the user is installing with NPM. Yarn works fine though, which is why we never noticed it here.
Rather than try to hack the dependency resolution, as this is already an incorrect peer dependency, I decided to simply remove it. I may try to update Critters or fork it later, but right now v4 is unusable for NPM users which isn't acceptable.
Does this PR introduce a breaking change?
Yes, see changeset