Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prawn 2.4.0 Compatibility #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathieujobin
Copy link

No description provided.

@mathieujobin
Copy link
Author

we are using this branch with Rails 7.x

is it possible to get it reviewed and released?

thanks

@robinboening
Copy link

I am not maintaing this repo, nor do I know the codebase, but reviewing your PR makes me want to drop some comments/suggestons:

The code changes in your commit aren't self-explanatory, so I went to see if the commit message explains it better. Unfortunately the commit message is completely meaningless. Thus, I don't understand your changes.

You're changing an expectation in a test case. Why, and it doesn't really seem related to making it compatible with Prawn 2.4.0, is it?

I think you should really provide some explanation. Maybe start with how it's currently not compatible with Prawn 2.4.0 and then what you're changing in order to achieve compatibility.

Thank you for considering my suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants