Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 464: Adding support for configuring pdb #466

Merged
merged 5 commits into from
Apr 21, 2022
Merged

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anishakj [email protected]

Change log description

Added support for configuring pdb
Also made crds in charts sync with config/crd/bases/crd

Purpose of the change

Fixes #464

What the code does

Provide support to configure pdb

How to verify it

All e2e should pass

@anishakj anishakj requested a review from nishant-yt April 20, 2022 06:58
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #466 (420fe2b) into master (a045229) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   85.01%   85.04%   +0.02%     
==========================================
  Files          12       12              
  Lines        1602     1605       +3     
==========================================
+ Hits         1362     1365       +3     
  Misses        155      155              
  Partials       85       85              
Impacted Files Coverage Δ
api/v1beta1/zookeepercluster_types.go 98.80% <100.00%> (+0.01%) ⬆️
pkg/zk/generators.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a045229...420fe2b. Read the comment docs.

Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Copy link
Contributor

@nishant-yt nishant-yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 06b7ddc into master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FTT=2 (Failures To Tolerate)
2 participants