Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golang 1.17 and update dependencies #420

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Dec 5, 2021

Change log description

  • Use golang 1.17
  • Upgrade k8s deps to 1.20

Purpose of the change

  • keep deps up to date

@amuraru amuraru force-pushed the updeps branch 2 times, most recently from afd9b6d to 950e668 Compare December 5, 2021 18:28
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #420 (20c3136) into master (f32c9fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files          12       12           
  Lines        1643     1643           
=======================================
  Hits         1382     1382           
  Misses        177      177           
  Partials       84       84           
Impacted Files Coverage Δ
...kg/apis/zookeeper/v1beta1/zz_generated.deepcopy.go 98.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32c9fe...20c3136. Read the comment docs.

@amuraru amuraru force-pushed the updeps branch 2 times, most recently from d5004e2 to 3b21afc Compare December 5, 2021 18:34
@anishakj
Copy link
Contributor

anishakj commented Dec 7, 2021

@amuraru Can we remove the v1beta1 version of CRD from charts as well

@amuraru
Copy link
Contributor Author

amuraru commented Dec 7, 2021

I'd personally prefer to do that in a separate PR and not here. wdyt?

@anishakj
Copy link
Contributor

anishakj commented Dec 7, 2021

I'd personally prefer to do that in a separate PR and not here. wdyt?

sure, that is absolutely fine

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 75d75e7 into pravega:master Dec 7, 2021
@amuraru amuraru deleted the updeps branch May 29, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants