Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 394: Allow to set pod annotations in post-install-upgrade job in helm chart #395

Conversation

petrkohut
Copy link
Contributor

Signed-off-by: Petr Kohut [email protected]

Change log description

  • Adds an option to add pod annotations to the zookeeper-post-install-upgrade K8s job.

Purpose of the change

Fixes #394

What the code does

  • adds additional property into values.yaml allowing to set pod annotations on post-install-upgrade job
  • updates the K8s manifest of post-install-upgrade Job

How to verify it

helm template test . --set hooks.pod.annotations.test=hello

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #395 (475eaaa) into master (4ceccde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          11       11           
  Lines        1578     1578           
=======================================
  Hits         1355     1355           
  Misses        147      147           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ceccde...475eaaa. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 575c49b into pravega:master Sep 29, 2021
@petrkohut petrkohut deleted the issue-394-post-install-upgrade-hooks-pod-annotations branch September 29, 2021 08:22
amuraru pushed a commit to adobe/zookeeper-operator that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set pod annotations in post-install-upgrade job in helm chart
2 participants