Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more endtoend tests #303

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Added more endtoend tests #303

merged 4 commits into from
Mar 2, 2021

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented Feb 24, 2021

Signed-off-by: anishakj [email protected]

Change log description

Adding more end to end tests

Purpose of the change

Fixes #304

What the code does

Added more tests for pull secret and admin service check

How to verify it

Tests should pass

@anishakj anishakj marked this pull request as ready for review February 26, 2021 08:04
@Prabhaker24 Prabhaker24 self-requested a review February 27, 2021 10:11
Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit cda03d2 into master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding more end to end tests
2 participants