-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support mutli images #230
support mutli images #230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 81.81% 81.16% -0.66%
==========================================
Files 11 11
Lines 1248 1258 +10
==========================================
Hits 1021 1021
- Misses 162 170 +8
- Partials 65 67 +2
Continue to review full report at Codecov.
|
@qixiaogang can you please add the steps for verification in the pr? |
@Prabhaker24 I doesn't get you about "the steps for verification in the PR", can you share more details? and sorry for reply so late. |
@Prabhaker24 Can you help with above comments |
@qixiaogang sorry I got busy with some other stuff. What I mean is you have removed the sections What the code does and How to verify from your pr description can you please add them back and explain what the code is doing there you can refer the following pr's description #215, Thanks. |
Thanks, get it. |
@Prabhaker24 Add the What the code does and How to verify back, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@anishakj Can you help to review the PR, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qixiaogang Could you please add the new fields in https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper/README.md, and https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper/values.yaml
Also, since new parameters are added in spec ,CRD have to be changed to include the changes
@anishakj Add new scripts in the two files and update the crd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change log description
Add image and volume array in the crd to support customize images deploy with zookeeper node.
Purpose of the change
Support multi images, issue: #228
What does the code do
This code allows users to add customized images and volumes in the pod spec, which means users can deploy other containers with the zookeeper.
To support multi containers, add containers and volumes to the manifest
spec: containers: # array of Container in k8s.io/api/core/v1 volumes: # array of Volume in k8s.io/api/core/v1
How to verify it
Create a ZookeeperCluster CR and add another image to the containers and define the volume in the volumes, then apply the ZookeeperCluster CR, you will find the zookeeper instance with start with the images define in the containers.