Issue 225: Removed k8s.io/kubernetes #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prabhaker24 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 11 11
Lines 1203 1203
=======================================
Hits 1003 1003
Misses 137 137
Partials 63 63 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prabhaker24 [email protected]
Change log description
The zookeeper-operator imports k8s.io/kubernetes, this isn't supposed used a library and is unsupported by the developers. It breaks a bunch of stuff in other components that rely on the zookeeper-operator.
Purpose of the change
Fixes #225
What the code does
I have run go mod tidy which removes all indirect dependencies and the k8s.io/kubernetes dependency from go.mod file
How to verify it
check the go.mod file it should not have k8s.io/kubernetes in it.