Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting resources for operator pod #203

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Jun 16, 2020

Purpose of the change

Fixes #202

What the code does

Add default resources for operator pod and ability to override them.

How to verify it

(Steps to verify that the changes are effective)

@amuraru amuraru changed the title ### Change log description Add support for setting resources for operator pod Add support for setting resources for operator pod Jun 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #203 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   82.41%   82.82%   +0.41%     
==========================================
  Files          11       11              
  Lines        1194     1223      +29     
==========================================
+ Hits          984     1013      +29     
  Misses        142      142              
  Partials       68       68              
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.18% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded6a82...9fcf029. Read the comment docs.

@anishakj anishakj requested a review from SrishT June 16, 2020 11:05
charts/zookeeper-operator/templates/operator.yaml Outdated Show resolved Hide resolved
charts/zookeeper-operator/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@SrishT SrishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit db0e746 into pravega:master Jun 18, 2020
@amuraru amuraru deleted the issue-202 branch July 6, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for setting resources for operator pod
4 participants