Updating zookeeper charts #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SrishT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 6 6
Lines 952 952
=======================================
Hits 456 456
Misses 467 467
Partials 29 29 Continue to review full report at Codecov.
|
derekm
reviewed
May 13, 2020
| @@ -1,4 +1,10 @@ | |||
| replicas: 3 | |||
There was a problem hiding this comment.
Nice! I found myself making this same change here: derekm@99fa885
anishakj
reviewed
May 13, 2020
| persistence: | ||
| accessModes: [ "ReadWriteOnce" ] | ||
| storageClassName: {{ .Values.storage.className }} | ||
| reclaimPolicy: Delete |
There was a problem hiding this comment.
Can we add reclaimPolicy also in values.yaml
added 2 commits
May 13, 2020 11:43
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SrishT [email protected]
Change log description
Updates the Zookeeper Operator charts.
How to verify it
Zookeeper Operator and zookeeper cluster should be deployed successfully both manually and using charts.