Customised docker file for docker swarm #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
pbelgundi
requested changes
Feb 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 48.42% 48.42%
=======================================
Files 5 5
Lines 921 921
=======================================
Hits 446 446
Misses 448 448
Partials 27 27Continue to review full report at Codecov.
|
Signed-off-by: anisha.kj <[email protected]>
|
It may help to have a new Make target to build this custom zookeeper image. |
Signed-off-by: anisha.kj <[email protected]>
Modified the Makefile to build image. |
pbelgundi
approved these changes
Feb 10, 2020
amuraru
pushed a commit
to amuraru/zookeeper-operator
that referenced
this pull request
Mar 4, 2020
* Customised docker file for docker swarm Signed-off-by: anisha.kj <[email protected]> * changed zookeeper vesrion Signed-off-by: anisha.kj <[email protected]> * Modified Makefile to build the swarm image Signed-off-by: anisha.kj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created docker file to whitelist the
ruokcommand.netstatgot removed fromzookeeper:3.5.5onwards. Customised docker file will be used for docker swarm tests.Fixes #122
Signed-off-by: anisha.kj [email protected]