Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update to zk 3.5.7 or 3.6.0 #164

Closed
AceHack opened this issue Apr 18, 2020 · 3 comments
Closed

Please update to zk 3.5.7 or 3.6.0 #164

AceHack opened this issue Apr 18, 2020 · 3 comments

Comments

@AceHack
Copy link

AceHack commented Apr 18, 2020

There are so many bug fixes please update
@amuraru
Copy link
Contributor

amuraru commented Apr 18, 2020

Issues #128 and #155 also require upgrade to zk 3.6

zk 3.6.1 is at this time in rc mode and due next week.
I suggest operator upgrades to 3.6.1 directly as that fixes a couple of issues in 3.6.0

@AceHack
Copy link
Author

AceHack commented Apr 18, 2020

Yes I would be happy for 3.6.1 next week.

amuraru added a commit to adobe/zookeeper-operator that referenced this issue May 11, 2020
@amuraru
Upgrade to zookeeper 3.6.1
efd6483 
Fixes:
- pravega#128
- pravega#155
- pravega#164

1. Upgrades `zu` utility to compile againstzookeeper 3.6.1

2. Upgrades the base image for pravega/zookeeper to zookeeper:3.6.1

3. Enable prometheus monitoring for zookeeper pods

Since 3.6.0 ZooKeeper supports native Prometheus monitoring
https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperMonitor.md#prometheus

This patch
- enables `PrometheusMetricsProvider` in zoo.cfg
- expose a new `metrics` port to ZK pods, ZK services
- disambiguate the headless and client service labels by adding a new label,
 so it can be used in Prometheus `ServiceMonitors`

For users using Prometheus Operator for monitoring the following
ServiceMonitor CR can be created to enable ZK cluster monitoring
deployed in `zookeeper` namespace

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: zookeeper-servicemonitor
  labels:
    app: zookeeper
    release: monitoring
spec:
  selector:
    matchLabels:
      app: zk
  namespaceSelector:
    matchNames:
    - zookeeper
  endpoints:
  - interval: 10s
    port: metrics
    path: /metrics
    honorLabels: true
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_ip]
      separator: ;
      regex: (.*)
      targetLabel: pod_ip
      replacement: $1
      action: replace
    - sourceLabels: [__meta_kubernetes_pod_name]
      separator: ;
      regex: (.*)
      targetLabel: pod_name
      replacement: $1
      action: replace
```
@amuraru amuraru mentioned this issue May 11, 2020
Merged
amuraru added a commit to adobe/zookeeper-operator that referenced this issue Jun 3, 2020
@amuraru
Upgrade to zookeeper 3.6.1
dede2ba 
Fixes:
- pravega#128
- pravega#155
- pravega#164

1. Upgrades `zu` utility to compile againstzookeeper 3.6.1

2. Upgrades the base image for pravega/zookeeper to zookeeper:3.6.1

3. Enable prometheus monitoring for zookeeper pods

Since 3.6.0 ZooKeeper supports native Prometheus monitoring
https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperMonitor.md#prometheus

This patch
- enables `PrometheusMetricsProvider` in zoo.cfg
- expose a new `metrics` port to ZK pods, ZK services
- disambiguate the headless and client service labels by adding a new label,
 so it can be used in Prometheus `ServiceMonitors`

For users using Prometheus Operator for monitoring the following
ServiceMonitor CR can be created to enable ZK cluster monitoring
deployed in `zookeeper` namespace

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: zookeeper-servicemonitor
  labels:
    app: zookeeper
    release: monitoring
spec:
  selector:
    matchLabels:
      app: zk
  namespaceSelector:
    matchNames:
    - zookeeper
  endpoints:
  - interval: 10s
    port: metrics
    path: /metrics
    honorLabels: true
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_ip]
      separator: ;
      regex: (.*)
      targetLabel: pod_ip
      replacement: $1
      action: replace
    - sourceLabels: [__meta_kubernetes_pod_name]
      separator: ;
      regex: (.*)
      targetLabel: pod_name
      replacement: $1
      action: replace
```
anishakj pushed a commit that referenced this issue Jun 6, 2020
@amuraru
Upgrade to zookeeper 3.6.1 (#175)
c80add8 
Fixes:
- #128
- #155
- #164

1. Upgrades `zu` utility to compile againstzookeeper 3.6.1

2. Upgrades the base image for pravega/zookeeper to zookeeper:3.6.1

3. Enable prometheus monitoring for zookeeper pods

Since 3.6.0 ZooKeeper supports native Prometheus monitoring
https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperMonitor.md#prometheus

This patch
- enables `PrometheusMetricsProvider` in zoo.cfg
- expose a new `metrics` port to ZK pods, ZK services
- disambiguate the headless and client service labels by adding a new label,
 so it can be used in Prometheus `ServiceMonitors`

For users using Prometheus Operator for monitoring the following
ServiceMonitor CR can be created to enable ZK cluster monitoring
deployed in `zookeeper` namespace

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: zookeeper-servicemonitor
  labels:
    app: zookeeper
    release: monitoring
spec:
  selector:
    matchLabels:
      app: zk
  namespaceSelector:
    matchNames:
    - zookeeper
  endpoints:
  - interval: 10s
    port: metrics
    path: /metrics
    honorLabels: true
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_ip]
      separator: ;
      regex: (.*)
      targetLabel: pod_ip
      replacement: $1
      action: replace
    - sourceLabels: [__meta_kubernetes_pod_name]
      separator: ;
      regex: (.*)
      targetLabel: pod_name
      replacement: $1
      action: replace
```
@anishakj
Copy link
Contributor

anishakj commented Jun 6, 2020

Fixed by PR #175

@anishakj anishakj closed this as completed Jun 6, 2020
whitleykeith pushed a commit to whitleykeith/zookeeper-operator that referenced this issue Jun 8, 2020
@amuraru
Upgrade to zookeeper 3.6.1 (pravega#175)
5f5d145 
Fixes:
- pravega#128
- pravega#155
- pravega#164

1. Upgrades `zu` utility to compile againstzookeeper 3.6.1

2. Upgrades the base image for pravega/zookeeper to zookeeper:3.6.1

3. Enable prometheus monitoring for zookeeper pods

Since 3.6.0 ZooKeeper supports native Prometheus monitoring
https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperMonitor.md#prometheus

This patch
- enables `PrometheusMetricsProvider` in zoo.cfg
- expose a new `metrics` port to ZK pods, ZK services
- disambiguate the headless and client service labels by adding a new label,
 so it can be used in Prometheus `ServiceMonitors`

For users using Prometheus Operator for monitoring the following
ServiceMonitor CR can be created to enable ZK cluster monitoring
deployed in `zookeeper` namespace

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: zookeeper-servicemonitor
  labels:
    app: zookeeper
    release: monitoring
spec:
  selector:
    matchLabels:
      app: zk
  namespaceSelector:
    matchNames:
    - zookeeper
  endpoints:
  - interval: 10s
    port: metrics
    path: /metrics
    honorLabels: true
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_ip]
      separator: ;
      regex: (.*)
      targetLabel: pod_ip
      replacement: $1
      action: replace
    - sourceLabels: [__meta_kubernetes_pod_name]
      separator: ;
      regex: (.*)
      targetLabel: pod_name
      replacement: $1
      action: replace
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AceHack @amuraru @anishakj