[issue-12] Implement rate limiting in micro batch reader #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Munish <[email protected]>
munish1789
requested review from
tkaitchuck,
ShwethaSNayak,
anju-c-das,
amit-kumar59 and
AnkurAnand11
Signed-off-by: Munish <[email protected]>
tkaitchuck
reviewed
Aug 10, 2023
src/main/scala/io/pravega/connectors/spark/PravegaMicroBatchStream.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/pravega/connectors/spark/PravegaMicroBatchStream.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
src/main/scala/io/pravega/connectors/spark/PravegaSourceProvider.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
crazyzhou
reviewed
Aug 11, 2023
src/main/scala/io/pravega/connectors/spark/PravegaMicroBatchStream.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/pravega/connectors/spark/PravegaSourceProvider.scala
Outdated
Show resolved
Hide resolved
src/test/scala/io/pravega/connectors/spark/PravegaMicroBatchSourceSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
crazyzhou
reviewed
Aug 22, 2023
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
munish1789
commented
Sep 12, 2023
src/main/scala/io/pravega/connectors/spark/PravegaMicroBatchStream.scala
Show resolved
Hide resolved
munish1789
commented
Sep 12, 2023
src/main/scala/io/pravega/connectors/spark/PravegaBatchPartitionReader.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
tkaitchuck
reviewed
Sep 19, 2023
src/main/scala/io/pravega/connectors/spark/PravegaBatchPartitionReader.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
munish1789
changed the title
Signed-off-by: Munish <[email protected]>
crazyzhou
reviewed
Sep 22, 2023
src/main/scala/io/pravega/connectors/spark/PravegaMicroBatchStream.scala
Show resolved
Hide resolved
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
Signed-off-by: Munish <[email protected]>
tkaitchuck
reviewed
Sep 22, 2023
src/main/scala/io/pravega/connectors/spark/PravegaBatchPartitionReader.scala
Outdated
Show resolved
Hide resolved
tkaitchuck
approved these changes
Sep 22, 2023
Signed-off-by: Munish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Implement rate limiting in micro batch reader
Purpose of the change
Fix #12
What the code does
Implements rateLimit feature to read in microbatches.
How to verify it
Start a reader and it should iterate as per the configured rate limit.