Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-255 Update Dependencies in Schema Registry #256

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

shshashwat
Copy link
Contributor

Signed-off-by: Shashwat Sharma [email protected]

Change log description
This PR updates several dependencies in Schema Registry with latest stable version. This PR also updates the gradle version. All these changes are now in sync with Pravega

Purpose of the change
Fixes #255

What the code does
Update the dependencies to the suggested versions in #255

How to verify it
All existing test cases should pass and no error should be found

Copy link
Contributor

@crazyzhou crazyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flink connector builds nicely against this schema-registry dependency. The dependency updates are compliant.

For gradle version updates, it's not only the property changes, it also contains the gradlew script and wrapper jar update, check gradle wrapper

Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, versions are aligned with Pravega dependency versions, which should reduce the probability of conflicts (if any). I'm ok as long as this build has been tested with downstream components using it (e.g., connectors).

@shshashwat
Copy link
Contributor Author

Flink connector builds nicely against this schema-registry dependency. The dependency updates are compliant.

For gradle version updates, it's not only the property changes, it also contains the gradlew script and wrapper jar update, check gradle wrapper

@crazyzhou, I have created a GH issue to track this:- #257
We will take it up soon after this.

Copy link
Contributor

@crazyzhou crazyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the wrapper issue would be taken care in the next release.
Approved.

@shshashwat shshashwat merged commit 1cbe66d into pravega:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Schema Registry Dependencies
3 participants