Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 242: Update Third Party Library Versions #243

Merged

Conversation

shshashwat
Copy link
Contributor

Signed-off-by: Shashwat Sharma [email protected]

Change log description
Few libraries version identified with possible vulnerabilities, this needs to be updated

Purpose of the change
Fixes #242

What the code does
Update the library version with possible vulnerabilities

How to verify it
All test cases should pass, Schema-Registry samples should work with Pravega Samples

Signed-off-by: Shashwat Sharma <[email protected]>
@kotlasaicharanreddy
Copy link
Contributor

@shshashwat could you please provide kind of tests performed on this ?

@shshashwat shshashwat changed the title Issue_242: Update Third Party Library Versions Issue 242: Update Third Party Library Versions Apr 20, 2022
@shshashwat
Copy link
Contributor Author

building and running Schema Registry samples with latest Pravega master is working fine in local

@shshashwat
Copy link
Contributor Author

shshashwat commented Apr 25, 2022

ObjectMapper.Configure is deprecated and as per the JavaDoc new way is to use JsonMapper.builder().configure(...).
Ref:- The Javadoc

Copy link
Contributor

@crazyzhou crazyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has brought the Flink connector a regression, two of the tests are failing for this change, and the main cause is the avro version upgrade.

Can you give the CVE number for the avro version upgrade and check if version 1.10.0 also works for you. Thanks.

We are still trying to fix it either from the schema registry or the connector itself.

@shshashwat
Copy link
Contributor Author

shshashwat commented Apr 28, 2022

Can you give the CVE number for the avro version upgrade and check if version 1.10.0 also works for you. Thanks.

@crazyzhou The changes made here was as per the issue-ticket created by Security scan. The suggested version in the ticket is 1.11.0 and hence it's changed here. If there is some backward compatibility related issue you're facing the way I faced here, that should be manageable.

Copy link
Contributor

@crazyzhou crazyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some more investigation, the connector can help to fix with some changes on the connector side, so I will unblock it here.

@RaulGracia RaulGracia merged commit 1629800 into pravega:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Third Party components in Schema-Registry
4 participants