-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 242: Update Third Party Library Versions #243
Issue 242: Update Third Party Library Versions #243
Conversation
Signed-off-by: Shashwat Sharma <[email protected]>
Signed-off-by: Shashwat Sharma <[email protected]>
@shshashwat could you please provide kind of tests performed on this ? |
building and running Schema Registry samples with latest Pravega master is working fine in local |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has brought the Flink connector a regression, two of the tests are failing for this change, and the main cause is the avro version upgrade.
Can you give the CVE number for the avro version upgrade and check if version 1.10.0
also works for you. Thanks.
We are still trying to fix it either from the schema registry or the connector itself.
@crazyzhou The changes made here was as per the issue-ticket created by Security scan. The suggested version in the ticket is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more investigation, the connector can help to fix with some changes on the connector side, so I will unblock it here.
Signed-off-by: Shashwat Sharma [email protected]
Change log description
Few libraries version identified with possible vulnerabilities, this needs to be updated
Purpose of the change
Fixes #242
What the code does
Update the library version with possible vulnerabilities
How to verify it
All test cases should pass, Schema-Registry samples should work with Pravega Samples