-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 240: Remove Netty dependencies #241
Issue 240: Remove Netty dependencies #241
Conversation
Signed-off-by: Shashwat Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tested both versions of Pravega(0.10.2 and 0.11.0) with this change on live cluster. Performed a few set of operations(creating a schema, editing the schema, deleting the schema) and it worked fine. |
@tkaitchuck, @sachin-j-joshi, @RaulGracia if you think we are good to go with the changes please take the next action else kindly provide your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shshashwat, before merging, please check that building and running Schema Registry samples in Pravega Samples is working fine: https://github.com/pravega/pravega-samples
@RaulGracia, I tried this also and was able to test them all successfully. Thank you |
Signed-off-by: Shashwat Sharma [email protected]
Change log description
Remove forced netty version from build.gradle causing conflicts with Pravega higher versions
Purpose of the change
fixes #240
How to verify it
The build should pass and all existing test cases should complete successfully