Issue 643: Pravega cluster upgrade is failing intermittently #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
Codecov ReportBase: 82.87% // Head: 82.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 82.87% 82.75% -0.13%
==========================================
Files 17 17
Lines 4077 4083 +6
==========================================
Hits 3379 3379
- Misses 564 567 +3
- Partials 134 137 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
derekm
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj [email protected]
Change log description
Pravega cluster upgrade is failing in certain cases. In failed scenarios, while deleting the pod, we are getting error pod not found. Due to that error upgrade status is set to failure and due to that subsequent upgrade of pods is not happening
Purpose of the change
Fixes #643
What the code does
Made changes to not return error in the case of pod deletion fails with pod not found error. This ensures that remaining pods can be upgraded successfully.
How to verify it
Verified upgrade of pravega cluster multiple times and is successful