Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 75: OpenApi Schema validation added #76

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anisha.kj [email protected]

Change log description

Added Support for OpenApiSchemaValidation

Purpose of the change

Fixes #75

What the code does

The code adds openapi schema validation, which checks data type checks and some value checks

How to verify it

Verified Installation of bk-operator and cluster manually and with helm charts
Verified upgrade of bk-operator and cluster manually and with helm charts

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #76 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   86.31%   86.35%   +0.03%     
==========================================
  Files           9        9              
  Lines        1542     1546       +4     
==========================================
+ Hits         1331     1335       +4     
  Misses        153      153              
  Partials       58       58              
Impacted Files Coverage Δ
...pis/bookkeeper/v1alpha1/bookkeepercluster_types.go 94.60% <ø> (ø)
pkg/apis/bookkeeper/v1alpha1/status.go 100.00% <ø> (ø)
.../apis/bookkeeper/v1alpha1/zz_generated.deepcopy.go 98.13% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af58c5...559798a. Read the comment docs.

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SrishT SrishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 829966c into master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add OpenApiSchemaValidation
4 participants