Updating busybox version to fix CVEs #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Gupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 11 11
Lines 1852 1852
=======================================
Hits 1471 1471
Misses 296 296
Partials 85 85 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jkhalack
reviewed
Aug 4, 2022
Dockerfile
Outdated
| @@ -41,9 +41,10 @@ RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o /src/${PROJECT_NAME} \ | |||
| # ============================================================================= | |||
| FROM ${DOCKER_REGISTRY:+$DOCKER_REGISTRY/}alpine:${ALPINE_VERSION} AS final | |||
|
|
|||
| RUN apk add --update \ | |||
| RUN apk add --upgrade \ | |||
There was a problem hiding this comment.
I think we should keep the update too.
The recommendation is to run the update first (it updates the list of available packages) and then the upgrade, as in
apk update
apk add --upgrade busybox
See the documentation: https://wiki.alpinelinux.org/wiki/Package_management#Upgrade_a_Running_System
There was a problem hiding this comment.
In Dockerfile, it would translate to RUN apk update && apk add --upgrade \
There was a problem hiding this comment.
Thanks @jkhalack for pointing it out. Will fix this
Signed-off-by: Nishant Gupta <[email protected]>
jkhalack
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nishant Gupta [email protected]
Change log description
Upgrade busybox version to 1.35.0-r17 so as to fix CVE-2022-30065 and CVE-2022-28391
Purpose of the change
Fixes #215
What the code does
upgrades busybox version to 1.35.0-r17
How to verify it
apk list | grep busyboxto check the installed version of busybox