Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 213: Upgrade of bookkeeper fails intermittently #214

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented Jul 18, 2022

Signed-off-by: anisha.kj [email protected]

Change log description

In some cases, after updating stateful set, updatedReplicas field in sts is not updating correctly. Due to this, the check

if sts.Status.UpdatedReplicas == sts.Status.Replicas &&
		sts.Status.UpdatedReplicas == sts.Status.ReadyReplicas 

is succeeding and make upgrade as completed. And pods are not coming up with new image

Purpose of the change

Fixes #213

What the code does

Added additional check to ensure that all the pods are updated with new version

How to verify it

Verified that upgrade is working

@anishakj anishakj requested a review from nishant-yt July 18, 2022 07:35
Signed-off-by: anisha.kj <[email protected]>
Copy link
Contributor

@nishant-yt nishant-yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go

@anishakj anishakj merged commit a064530 into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade of bookkeeper cluster is failing intermittently
2 participants