GDV-94:[C++][Java]Fixed literals and nulls for time types. (apache#72)

Added support for literals and null for time types.
praveenbingo · Jul 23, 2018 · edb0fc5 · edb0fc5
1 parent 983f8a7
commit edb0fc5
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/codegen/llvm_generator.cc b/src/codegen/llvm_generator.cc
@@ -523,6 +523,22 @@ void LLVMGenerator::Visitor::Visit(const LiteralDex &dex) {
       break;
     }
 
+    case arrow::Type::DATE64:
+      value = types->i64_constant(boost::get<int64_t>(dex.holder()));
+      break;
+
+    case arrow::Type::TIME32:
+      value = types->i32_constant(boost::get<int32_t>(dex.holder()));
+      break;
+
+    case arrow::Type::TIME64:
+      value = types->i64_constant(boost::get<int64_t>(dex.holder()));
+      break;
+
+    case arrow::Type::TIMESTAMP:
+      value = types->i64_constant(boost::get<int64_t>(dex.holder()));
+      break;
+
     default:
       DCHECK(0);
   }

diff --git a/src/codegen/tree_expr_builder.cc b/src/codegen/tree_expr_builder.cc
@@ -78,6 +78,14 @@ NodePtr TreeExprBuilder::MakeNull(DataTypePtr data_type) {
     case arrow::Type::STRING:
     case arrow::Type::BINARY:
       return std::make_shared<LiteralNode>(data_type, LiteralHolder(empty), true);
+    case arrow::Type::DATE64:
+      return std::make_shared<LiteralNode>(data_type, LiteralHolder((int64_t)0), true);
+    case arrow::Type::TIME32:
+      return std::make_shared<LiteralNode>(data_type, LiteralHolder((int32_t)0), true);
+    case arrow::Type::TIME64:
+      return std::make_shared<LiteralNode>(data_type, LiteralHolder((int64_t)0), true);
+    case arrow::Type::TIMESTAMP:
+      return std::make_shared<LiteralNode>(data_type, LiteralHolder((int64_t)0), true);
     default:
       return nullptr;
   }