Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Observe events for submit buttons #5

Closed
elimillera opened this issue Jul 13, 2021 · 2 comments
Closed

JOSS Review: Observe events for submit buttons #5

elimillera opened this issue Jul 13, 2021 · 2 comments

Comments

@elimillera
Copy link
Contributor

This is related to #4 . Not necessarily something that should hold up a review, just a recommendation.

In several places input$submit > 0 or is.null(input$submit) is used. If you are only looking to update the displays when a submitting button is pressed, the shiny::observeEvent function would be the solution to that. You could wrap the derivation of tables and plots in that to only have the outputs change on a update to input$submit. Right now the application is reactive when the submit button has been pressed but not otherwise.

@pratheesh3780
Copy link
Owner

Hi,
Thank you for your valuable comments. I will incorporate it and get back to you soon!
Thank you

@pratheesh3780
Copy link
Owner

Hi,
App is working fine now. But I believe, I should make this change. So will do it soon
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants