Skip to content

Commit

Permalink
fix mistake in runner workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
prasadtalasila committed Nov 4, 2024
1 parent bf7f0a2 commit 1849faf
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
if: |
(startsWith(github.ref, 'refs/heads/feature/') || startsWith(github.ref, 'refs/heads/release-v'))
name: Publish to GitHub Packages
name: Publish to github npm registry
needs: [test-runner]
uses: ./.github/workflows/publish-npm.yml
with:
Expand All @@ -88,7 +88,7 @@ jobs:
if: |
(startsWith(github.ref, 'refs/heads/feature/') || startsWith(github.ref, 'refs/heads/release-v'))
name: Publish to GitHub Packages
name: Publish to npmjs registry
needs: [test-runner]
uses: ./.github/workflows/publish-npm.yml
with:
Expand Down
18 changes: 17 additions & 1 deletion docs/developer/github-actions.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Secrets for Github Action
# Github Action

## Secrets

The Github actions require the following secrets to be obtained
from [docker hub](hub.docker.com) and [npm](npmjs.com):
Expand All @@ -15,3 +17,17 @@ from [docker hub](hub.docker.com) and [npm](npmjs.com):
Remember to add these secrets to
[Github Secrets Setting](https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-a-repository)
of your fork.

## Environment Variables

The Github actions also require the following environment variables to be
added to your Github repository settings.

| Secret Name | Explanation |
|:---|:---|
| `NPM_LIBMS_PACKAGE_NAME` | Name of npm package for lib microservice |
| `NPM_RUNNER_PACKAGE_NAME` | Name of npm package for runner microservice |

Remember to add these variables to
[Github repository variables](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository)
of your fork.

0 comments on commit 1849faf

Please sign in to comment.