Skip to content

Commit

Permalink
drm: exynos: Fix vblank refcount
Browse files Browse the repository at this point in the history
Revert "drm/exynos: enable vsync interrupt while waiting for vblank"

This reverts commit 5d39b9e.

This fixes closing twice :

- starting gdm, stopping, then starting it anew:

[  201.440447] kernel BUG at drivers/gpu/drm/drm_irq.c:1032!
[  201.444737] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
[  201.450553] Modules linked in: bnep cfg80211 nfsd auth_rpcgss oid_registry nfs_acl nfs lockd grace sunrpc r8712u(C) smsc95xx usbnet mii btusb bluetooth rfkill vfat fat s5p_csis s5p_fimc snd_soc_odroidx2_max98
090 v4l2_mem2mem videobuf2_dma_contig videobuf2_memops exynos4_is_common videobuf2_core v4l2_common videodev media snd_soc_i2s snd_soc_idma snd_soc_max98090 ehci_exynos s5p_sss phy_exynos_mipi_video s3c2410_wdt
exynosdrm(O) drm_kms_helper phy_exynos_usb2 fuse
[  201.491526] CPU: 0 PID: 2173 Comm: Xorg Tainted: G         C O   3.18.0-rc3-00168-gd9d00f7-dirty torvalds#69
[  201.500637] task: e22e8000 ti: e5ace000 task.ti: e5ace000
[  201.506026] PC is at drm_vblank_put+0x2c/0xec
[  201.510484] LR is at mixer_wait_for_vblank+0x13c/0x148 [exynosdrm]
[  201.516522] pc : [<c040102c>]    lr : [<bf056bc8>]    psr: 60010053
[  201.516522] sp : e5acfcf8  ip : e5acfd08  fp : e5acfd04
[  201.527977] r10: e5acfe64  r9 : e7a1cdc0  r8 : eade0a80
[  201.533185] r7 : bf06da98  r6 : eae99a1c  r5 : eae998d0  r4 : 0000000a
[  201.539695] r3 : eaca2a00  r2 : 00000000  r1 : 00000000  r0 : eb6e2bc0
[  201.546207] Flags: nZCv  IRQs on  FIQs off  Mode SVC_32  ISA ARM  Segment user
[  201.553410] Control: 10c5387d  Table: 65abc04a  DAC: 00000015
[  201.559139] Process Xorg (pid: 2173, stack limit = 0xe5ace248)
[  201.564954] Stack: (0xe5acfcf8 to 0xe5ad0000)
[  201.569296] fce0:                                                       e5acfd3c e5acfd08
[  201.577458] fd00: bf056bc8 c040100c c004f4a0 00000000 e22e8000 c00644c8 e5acfd18 e5acfd18
[  201.585617] fd20: eac16880 eb6e2e7c eb6e2bc0 e7a1cdc0 e5acfd54 e5acfd40 bf046a34 bf056a98
[  201.593776] fd40: e7a1cdc4 eb6e2e10 e5acfd84 e5acfd58 bf047298 bf0469fc bf04727c e7a1cdc4
[  201.601935] fd60: eb6e2e10 eb6e2bc0 e7a1cdc0 eade0a80 eade0a80 e5acfe64 e5acfda4 e5acfd88
[  201.610094] fd80: c0408cd8 bf047288 e7a1cdc0 e7a1cdc0 eb6e2bc0 eb6e2bc0 e5acfdc4 e5acfda8
[  201.618253] fda0: c0408d5c c0408c88 eb6e2dc0 c0a844f4 e5acfddc e7a1cdc0 e5acfe0c e5acfdc8
[  201.626412] fdc0: c0409244 c0408ce8 eade0aec c0a844f4 e5acfdfc e5acfde0 c06ca1d8 c006c158
[  201.634572] fde0: e7a1cdc0 eade0aec eb6e2e10 e7a1cdc0 eade0aec eb6e2e10 eb6e2bc0 eade0a80
[  201.642731] fe00: e5acfe34 e5acfe10 c040cee4 c0409134 c040ce10 c0a1540c c0b3515c 000000af
[  201.650890] fe20: eb6e2bc0 e5acfe64 e5acff14 e5acfe38 c03ff900 c040ce1c e5ace020 0000081f
[  201.659049] fe40: b700b3d4 e2031680 c040ce10 c07250b8 00000004 be833b04 00000004 c00464af
[  201.667208] fe60: e5acfeac 0000001b c01476f4 c06c3a78 00000000 c016cfc8 00000000 00000800
[  201.675368] fe80: 00000008 000000a9 e2fab220 e4c73c80 e2fab220 e2fab220 00000008 00000000
[  201.683528] fea0: e5acfec4 e5acfeb0 c016cfc8 c01474e4 00408000 e4c73c30 e5acfed4 e5acfec8
[  201.691686] fec0: c016d044 c016cf8c e5acfefc e5acfed8 c016d250 0000081f c06ce9d4 c0a1c324
[  201.699845] fee0: b700b3d4 dc8cb000 b6fea010 e3854900 e3854900 00000007 be833b04 eaca5c18
[  201.708004] ff00: be833b04 00000000 e5acff7c e5acff18 c0169e94 c03ff578 c015a190 c0176e20
[  201.716163] ff20: 00000020 00000000 00000000 e5856008 e5acff54 e22e8504 00000000 c0a81ea4
[  201.724323] ff40: e22e8000 c00438c8 e5ace000 00000000 e5acff6c e3854900 e3854900 c00464af
[  201.732482] ff60: be833b04 00000007 e5ace000 00000000 e5acffa4 e5acff80 c0169f20 c0169900
[  201.740641] ff80: 00000000 b7003a40 be833b04 c00464af 00000036 c000fac4 00000000 e5acffa8
[  201.748800] ffa0: c000f880 c0169ee8 b7003a40 be833b04 00000007 c00464af be833b04 00000000
[  201.756960] ffc0: b7003a40 be833b04 c00464af 00000036 b6fd7000 b6fea010 b6fde754 b6fea478
[  201.765119] ffe0: b6d26664 be833ae4 b6d12b03 b6b40406 80010070 00000007 5a5a5a5a 5a5a5a5a
[  201.773354] [<c040102c>] (drm_vblank_put) from [<bf056bc8>] (mixer_wait_for_vblank+0x13c/0x148 [exynosdrm])
[  201.783101] [<bf056bc8>] (mixer_wait_for_vblank [exynosdrm]) from [<bf046a34>] (exynos_drm_crtc_complete_scanout+0x44/0x58 [exynosdrm])
[  201.795231] [<bf046a34>] (exynos_drm_crtc_complete_scanout [exynosdrm]) from [<bf047298>] (exynos_drm_fb_destroy+0x1c/0xd8 [exynosdrm])
[  201.807355] [<bf047298>] (exynos_drm_fb_destroy [exynosdrm]) from [<c0408cd8>] (drm_framebuffer_free+0x5c/0x60)
[  201.817379] [<c0408cd8>] (drm_framebuffer_free) from [<c0408d5c>] (drm_framebuffer_unreference+0x80/0x8c)
[  201.826925] [<c0408d5c>] (drm_framebuffer_unreference) from [<c0409244>] (drm_framebuffer_remove+0x11c/0x128)
[  201.836820] [<c0409244>] (drm_framebuffer_remove) from [<c040cee4>] (drm_mode_rmfb+0xd4/0xfc)
[  201.845325] [<c040cee4>] (drm_mode_rmfb) from [<c03ff900>] (drm_ioctl+0x394/0x57c)
[  201.852881] [<c03ff900>] (drm_ioctl) from [<c0169e94>] (do_vfs_ioctl+0x5a0/0x5e8)
[  201.860342] [<c0169e94>] (do_vfs_ioctl) from [<c0169f20>] (SyS_ioctl+0x44/0x6c)
[  201.867638] [<c0169f20>] (SyS_ioctl) from [<c000f880>] (ret_fast_syscall+0x0/0x30)
[  201.875182] Code: e0833102 e5932064 e3520000 1a000000 (e7f001f2)
[  201.881258] ---[ end trace 0261a23fb128fce8 ]---
[  201.885856] BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:41
[  201.894187] in_atomic(): 0, irqs_disabled(): 128, pid: 2173, name: Xorg
[  201.900787] CPU: 0 PID: 2173 Comm: Xorg Tainted: G      D  C O   3.18.0-rc3-00168-gd9d00f7-dirty torvalds#69
[  201.909911] [<c0017d5c>] (unwind_backtrace) from [<c0013a48>] (show_stack+0x20/0x24)
[  201.917630] [<c0013a48>] (show_stack) from [<c06c61d0>] (dump_stack+0x88/0xc8)
[  201.924841] [<c06c61d0>] (dump_stack) from [<c004c66c>] (__might_sleep+0x164/0x16c)
[  201.932475] [<c004c66c>] (__might_sleep) from [<c06cab20>] (down_read+0x2c/0x60)
[  201.939853] [<c06cab20>] (down_read) from [<c00371fc>] (exit_signals+0x28/0x154)
[  201.947231] [<c00371fc>] (exit_signals) from [<c002bb78>] (do_exit+0x118/0x9e8)
[  201.954518] [<c002bb78>] (do_exit) from [<c0013d24>] (die+0x2d8/0x308)
[  201.961027] [<c0013d24>] (die) from [<c0013db4>] (arm_notify_die+0x60/0x64)
[  201.967972] [<c0013db4>] (arm_notify_die) from [<c000841c>] (do_undefinstr+0x1dc/0x1f8)
[  201.975962] [<c000841c>] (do_undefinstr) from [<c06ccdec>] (__und_svc_finish+0x0/0x34)
[  201.983851] Exception stack(0xe5acfc70 to 0xe5acfcb8)
[  201.988888] fc60:                                     eb6e2bc0 00000000 00000000 eaca2a00
[  201.997049] fc80: 0000000a eae998d0 eae99a1c bf06da98 eade0a80 e7a1cdc0 e5acfe64 e5acfd04
[  202.005206] fca0: e5acfd08 e5acfcf8 bf056bc8 c040102c 60010053 ffffffff
[  202.011808] [<c06ccdec>] (__und_svc_finish) from [<c040102c>] (drm_vblank_put+0x2c/0xec)
[  202.019944] [<c040102c>] (drm_vblank_put) from [<bf056bc8>] (mixer_wait_for_vblank+0x13c/0x148 [exynosdrm])
[  202.029694] [<bf056bc8>] (mixer_wait_for_vblank [exynosdrm]) from [<bf046a34>] (exynos_drm_crtc_complete_scanout+0x44/0x58 [exynosdrm])
[  202.041829] [<bf046a34>] (exynos_drm_crtc_complete_scanout [exynosdrm]) from [<bf047298>] (exynos_drm_fb_destroy+0x1c/0xd8 [exynosdrm])
[  202.053950] [<bf047298>] (exynos_drm_fb_destroy [exynosdrm]) from [<c0408cd8>] (drm_framebuffer_free+0x5c/0x60)
[  202.063978] [<c0408cd8>] (drm_framebuffer_free) from [<c0408d5c>] (drm_framebuffer_unreference+0x80/0x8c)
[  202.073524] [<c0408d5c>] (drm_framebuffer_unreference) from [<c0409244>] (drm_framebuffer_remove+0x11c/0x128)
[  202.083418] [<c0409244>] (drm_framebuffer_remove) from [<c040cee4>] (drm_mode_rmfb+0xd4/0xfc)
[  202.091922] [<c040cee4>] (drm_mode_rmfb) from [<c03ff900>] (drm_ioctl+0x394/0x57c)
[  202.099476] [<c03ff900>] (drm_ioctl) from [<c0169e94>] (do_vfs_ioctl+0x5a0/0x5e8)
[  202.106940] [<c0169e94>] (do_vfs_ioctl) from [<c0169f20>] (SyS_ioctl+0x44/0x6c)
[  202.114233] [<c0169f20>] (SyS_ioctl) from [<c000f880>] (ret_fast_syscall+0x0/0x30)

- starting retroarch, closing it , then starting it anew:

[  259.913036] kernel BUG at drivers/gpu/drm/drm_irq.c:1032!
[  259.917372] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
[  259.923238] Modules linked in: cfg80211 bnep nfsd auth_rpcgss oid_registry nfs_acl nfs lockd grace sunrpc r8712u(C) smsc95xx usbnet mii btusb bluetooth rfkill vfat fat s5p_csis s5p_fimc v4l2_mem2mem videobuf2
_dma_contig videobuf2_memops exynos4_is_common videobuf2_core v4l2_common videodev snd_soc_odroidx2_max98090 media snd_soc_i2s snd_soc_max98090 snd_soc_idma ehci_exynos s5p_sss s3c2410_wdt phy_exynos_mipi_video
exynosdrm(O) drm_kms_helper phy_exynos_usb2 fuse
[  259.964669] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G         C O   3.18.0-rc3-00168-gd9d00f7-dirty torvalds#69
[  259.974405] task: c0a19da8 ti: c0a0c000 task.ti: c0a0c000
[  259.979802] PC is at drm_vblank_put+0x2c/0xec
[  259.984244] LR is at exynos_drm_crtc_finish_pageflip+0xc4/0xf4 [exynosdrm]
[  259.991103] pc : [<c040102c>]    lr : [<bf046900>]    psr: 600001d3
[  259.991103] sp : c0a0dd98  ip : c0a0dda8  fp : c0a0dda4
[  260.006095] r10: 00100100  r9 : eac117c0  r8 : 00200200
[  260.009687] r7 : eb6dabc0  r6 : 00000000  r5 : eaf77d00  r4 : eaf77d00
[  260.015777] r3 : eaf73b80  r2 : 00000000  r1 : 00000000  r0 : eb6dabc0
[  260.022317] Flags: nZCv  IRQs off  FIQs off  Mode SVC_32  ISA ARM  Segment kernel
[  260.029875] Control: 10c5387d  Table: 602ec04a  DAC: 00000015
[  260.035658] Process swapper/0 (pid: 0, stack limit = 0xc0a0c248)
[  260.041720] Stack: (0xc0a0dd98 to 0xc0a0e000)
[  260.046106] dd80:                                                       c0a0dde4 c0a0dda8
[  260.054378] dda0: bf046900 c040100c 00000103 200001d3 eac11b10 eb6dad20 00000000 eaec9e50
[  260.062611] ddc0: 00000801 eaec9e9c 00000801 00000001 00000000 00000000 c0a0de04 c0a0dde8
[  260.070793] dde0: bf056c34 bf046848 eb7ca800 edc1cddc 0000007b 00000000 c0a0de4c c0a0de08
[  260.078969] de00: c007dde8 bf056be0 c0a0de64 c0a0de18 c0a7292c edc1cd80 c0a72bf8 c0a72c14
[  260.087184] de20: 18be26c7 edc1cd80 edc1cddc eb7ca800 00000000 00000001 c0a0df00 edc176c0
[  260.095416] de40: c0a0de6c c0a0de50 c007dff8 c007dd4c 00000000 edc1cd80 edc1cddc c0a4379c
[  260.103656] de60: c0a0de8c c0a0de70 c0080e60 c007dfb8 c0080d54 0000007b 00000000 0000007b
[  260.111877] de80: c0a0dea4 c0a0de90 c007d3e0 c0080d60 000000bf c0a08fb0 c0a0ded4 c0a0dea8
[  260.120069] dea0: c007d710 c007d3b0 c0a0df00 f881000c 0000007b 0000006b c0a16a78 c0a0df00
[  260.128285] dec0: f8810000 c0a733bc c0a0defc c0a0ded8 c00086d8 c007d664 c001057c 60000053
[  260.136491] dee0: ffffffff c0a0df34 00000000 c0a0c000 c0a0df54 c0a0df00 c06ccd40 c0008688
[  260.144715] df00: ffffffed 00000000 ffffffed c0023980 c0a0c018 c0a154ec c06d2cf8 00000000
[  260.152925] df20: 00000000 c0a0c000 c0a733bc c0a0df54 c0a0df58 c0a0df48 c0010578 c001057c
[  260.161142] df40: 60000053 ffffffff c0a0df94 c0a0df58 c0064a2c c0010544 00000001 c0a0c000
[  260.169365] df60: c0a0df84 c0a0df70 c0a09f80 c0a72929 00000000 c0a167f0 c0a09f80 c0a091c8
[  260.177567] df80: c06c7928 c0a15400 c0a0dfac c0a0df98 c06c060c c0064810 c0a0c000 c0a16570
[  260.185753] dfa0: c0a0dff4 c0a0dfb0 c0992d80 c06c0584 ffffffff ffffffff c0992638 00000000
[  260.193989] dfc0: 00000000 c09daa38 00000000 c0a80e94 c0a1547c c09daa34 c0a1b208 4000406a
[  260.202209] dfe0: 413fc090 00000000 00000000 c0a0dff8 40008070 c0992990 00000000 00000000
[  260.210483] [<c040102c>] (drm_vblank_put) from [<bf046900>] (exynos_drm_crtc_finish_pageflip+0xc4/0xf4 [exynosdrm])
[  260.221140] [<bf046900>] (exynos_drm_crtc_finish_pageflip [exynosdrm]) from [<bf056c34>] (mixer_irq_handler+0x60/0x110 [exynosdrm])
[  260.232991] [<bf056c34>] (mixer_irq_handler [exynosdrm]) from [<c007dde8>] (handle_irq_event_percpu+0xa8/0x26c)
[  260.243118] [<c007dde8>] (handle_irq_event_percpu) from [<c007dff8>] (handle_irq_event+0x4c/0x6c)
[  260.252056] [<c007dff8>] (handle_irq_event) from [<c0080e60>] (handle_fasteoi_irq+0x10c/0x1a8)
[  260.260676] [<c0080e60>] (handle_fasteoi_irq) from [<c007d3e0>] (generic_handle_irq+0x3c/0x4c)
[  260.269328] [<c007d3e0>] (generic_handle_irq) from [<c007d710>] (__handle_domain_irq+0xb8/0xe4)
[  260.278055] [<c007d710>] (__handle_domain_irq) from [<c00086d8>] (gic_handle_irq+0x5c/0x78)
[  260.286467] [<c00086d8>] (gic_handle_irq) from [<c06ccd40>] (__irq_svc+0x40/0x74)
[  260.294064] Exception stack(0xc0a0df00 to 0xc0a0df48)
[  260.299921] df00: ffffffed 00000000 ffffffed c0023980 c0a0c018 c0a154ec c06d2cf8 00000000
[  260.308388] df20: 00000000 c0a0c000 c0a733bc c0a0df54 c0a0df58 c0a0df48 c0010578 c001057c
[  260.316929] df40: 60000053 ffffffff
[  260.322986] [<c06ccd40>] (__irq_svc) from [<c001057c>] (arch_cpu_idle+0x44/0x48)
[  260.330892] [<c001057c>] (arch_cpu_idle) from [<c0064a2c>] (cpu_startup_entry+0x228/0x43c)
[  260.339786] [<c0064a2c>] (cpu_startup_entry) from [<c06c060c>] (rest_init+0x94/0x98)
[  260.348245] [<c06c060c>] (rest_init) from [<c0992d80>] (start_kernel+0x3fc/0x408)
[  260.356491] Code: e0833102 e5932064 e3520000 1a000000 (e7f001f2)
[  260.363444] ---[ end trace 741583fda3bdfbd0 ]---
[  260.369952] Kernel panic - not syncing: Fatal exception in interrupt
[  274.220295] BUG: spinlock lockup suspected on CPU#0, swapper/0/0
[  274.227876]  lock: 0xeaec9e9c, .magic: dead4ead, .owner: swapper/0/0, .owner_cpu: 0
[  274.237063] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G      D  C O   3.18.0-rc3-00168-gd9d00f7-dirty torvalds#69
[  274.247905] [<c0017d5c>] (unwind_backtrace) from [<c0013a48>] (show_stack+0x20/0x24)
[  274.257202] [<c0013a48>] (show_stack) from [<c06c61d0>] (dump_stack+0x88/0xc8)
[  274.265928] [<c06c61d0>] (dump_stack) from [<c06c1fb4>] (spin_dump+0x94/0x9c)
[  274.274525] [<c06c1fb4>] (spin_dump) from [<c006db4c>] (do_raw_spin_lock+0x100/0x1a0)
[  274.283849] [<c006db4c>] (do_raw_spin_lock) from [<c06cc2ec>] (_raw_spin_lock_irqsave+0x30/0x38)
[  274.294220] [<c06cc2ec>] (_raw_spin_lock_irqsave) from [<bf0579b8>] (mixer_win_commit+0x910/0xc2c [exynosdrm])
[  274.305845] [<bf0579b8>] (mixer_win_commit [exynosdrm]) from [<bf04698c>] (exynos_drm_crtc_plane_commit+0x2c/0x30 [exynosdrm])
[  274.318923] [<bf04698c>] (exynos_drm_crtc_plane_commit [exynosdrm]) from [<bf049458>] (exynos_plane_commit+0x24/0x28 [exynosdrm])
[  274.332328] [<bf049458>] (exynos_plane_commit [exynosdrm]) from [<bf046300>] (exynos_drm_crtc_commit+0x2c/0x54 [exynosdrm])
[  274.345263] [<bf046300>] (exynos_drm_crtc_commit [exynosdrm]) from [<bf046484>] (exynos_drm_crtc_mode_set_commit.isra.1+0x98/0xa8 [exynosdrm])
[  274.359941] [<bf046484>] (exynos_drm_crtc_mode_set_commit.isra.1 [exynosdrm]) from [<bf0464ac>] (exynos_drm_crtc_mode_set_base+0x18/0x1c [exynosdrm])
[  274.375305] [<bf0464ac>] (exynos_drm_crtc_mode_set_base [exynosdrm]) from [<bf0264cc>] (drm_crtc_helper_set_config+0x80c/0x9cc [drm_kms_helper])
[  274.390222] [<bf0264cc>] (drm_crtc_helper_set_config [drm_kms_helper]) from [<c0408dac>] (drm_mode_set_config_internal+0x44/0xf0)
[  274.403895] [<c0408dac>] (drm_mode_set_config_internal) from [<bf02d6f0>] (restore_fbdev_mode+0xe8/0x108 [drm_kms_helper])
[  274.417019] [<bf02d6f0>] (restore_fbdev_mode [drm_kms_helper]) from [<bf02da80>] (drm_fb_helper_force_kernel_mode+0x68/0x9c [drm_kms_helper])
[  274.431894] [<bf02da80>] (drm_fb_helper_force_kernel_mode [drm_kms_helper]) from [<bf02db24>] (drm_fb_helper_panic+0x38/0x44 [drm_kms_helper])
[  274.446943] [<bf02db24>] (drm_fb_helper_panic [drm_kms_helper]) from [<c00462c4>] (notifier_call_chain+0x54/0x94)
[  274.459472] [<c00462c4>] (notifier_call_chain) from [<c0046600>] (atomic_notifier_call_chain+0x44/0x58)
[  274.471182] [<c0046600>] (atomic_notifier_call_chain) from [<c06c1844>] (panic+0xcc/0x224)
[  274.481748] [<c06c1844>] (panic) from [<c0013cf4>] (die+0x2a8/0x308)
[  274.490376] [<c0013cf4>] (die) from [<c0013db4>] (arm_notify_die+0x60/0x64)
[  274.499577] [<c0013db4>] (arm_notify_die) from [<c000841c>] (do_undefinstr+0x1dc/0x1f8)
[  274.509870] [<c000841c>] (do_undefinstr) from [<c06ccdec>] (__und_svc_finish+0x0/0x34)
[  274.520123] Exception stack(0xc0a0dd10 to 0xc0a0dd58)
[  274.528108] dd00:                                     eb6dabc0 00000000 00000000 eaf73b80
[  274.538623] dd20: eaf77d00 eaf77d00 00000000 eb6dabc0 00200200 eac117c0 00100100 c0a0dda4
[  274.549124] dd40: c0a0dda8 c0a0dd98 bf046900 c040102c 600001d3 ffffffff
[  274.558034] [<c06ccdec>] (__und_svc_finish) from [<c040102c>] (drm_vblank_put+0x2c/0xec)
[  274.568502] [<c040102c>] (drm_vblank_put) from [<bf046900>] (exynos_drm_crtc_finish_pageflip+0xc4/0xf4 [exynosdrm])
[  274.581430] [<bf046900>] (exynos_drm_crtc_finish_pageflip [exynosdrm]) from [<bf056c34>] (mixer_irq_handler+0x60/0x110 [exynosdrm])
[  274.595800] [<bf056c34>] (mixer_irq_handler [exynosdrm]) from [<c007dde8>] (handle_irq_event_percpu+0xa8/0x26c)
[  274.608413] [<c007dde8>] (handle_irq_event_percpu) from [<c007dff8>] (handle_irq_event+0x4c/0x6c)
[  274.619814] [<c007dff8>] (handle_irq_event) from [<c0080e60>] (handle_fasteoi_irq+0x10c/0x1a8)
[  274.630931] [<c0080e60>] (handle_fasteoi_irq) from [<c007d3e0>] (generic_handle_irq+0x3c/0x4c)
[  274.642032] [<c007d3e0>] (generic_handle_irq) from [<c007d710>] (__handle_domain_irq+0xb8/0xe4)
[  274.653171] [<c007d710>] (__handle_domain_irq) from [<c00086d8>] (gic_handle_irq+0x5c/0x78)
[  274.663965] [<c00086d8>] (gic_handle_irq) from [<c06ccd40>] (__irq_svc+0x40/0x74)
[  274.673915] Exception stack(0xc0a0df00 to 0xc0a0df48)
[  274.682075] df00: ffffffed 00000000 ffffffed c0023980 c0a0c018 c0a154ec c06d2cf8 00000000
[  274.692772] df20: 00000000 c0a0c000 c0a733bc c0a0df54 c0a0df58 c0a0df48 c0010578 c001057c
[  274.703444] df40: 60000053 ffffffff
[  274.711547] [<c06ccd40>] (__irq_svc) from [<c001057c>] (arch_cpu_idle+0x44/0x48)
[  274.721431] [<c001057c>] (arch_cpu_idle) from [<c0064a2c>] (cpu_startup_entry+0x228/0x43c)
[  274.732202] [<c0064a2c>] (cpu_startup_entry) from [<c06c060c>] (rest_init+0x94/0x98)
[  274.742445] [<c06c060c>] (rest_init) from [<c0992d80>] (start_kernel+0x3fc/0x408)
  • Loading branch information
prahal committed Nov 9, 2014
1 parent 5e6ad1e commit f5cd324
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/gpu/drm/exynos/exynos_mixer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1030,8 +1030,6 @@ static void mixer_wait_for_vblank(struct exynos_drm_manager *mgr)
}
mutex_unlock(&mixer_ctx->mixer_mutex);

drm_vblank_get(mgr->crtc->dev, mixer_ctx->pipe);

atomic_set(&mixer_ctx->wait_vsync_event, 1);

/*
Expand All @@ -1042,8 +1040,6 @@ static void mixer_wait_for_vblank(struct exynos_drm_manager *mgr)
!atomic_read(&mixer_ctx->wait_vsync_event),
HZ/20))
DRM_DEBUG_KMS("vblank wait timed out.\n");

drm_vblank_put(mgr->crtc->dev, mixer_ctx->pipe);
}

static void mixer_window_suspend(struct exynos_drm_manager *mgr)
Expand Down

0 comments on commit f5cd324

Please sign in to comment.