-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing GFM table support #278
Comments
Thank you for reporting this. We are definitely going for maximal GFM compatibility however this seems a minor difference to me, is this an issue for you? I will definitely keep this open but assign it low priority for now. If this is a problem for your application, please tell me more. Thx again |
Hey Robert, thank you for responding! Our application allows importing markdown files, so the input is entirely out of our control. It does present a problem when the user expects to the same render result as in GitHub. FYI, both this bug and #279 were caught through https://github.com/louthy/language-ext/blob/master/README.md. |
Ok if I can adapt the table behavior to the GFM behavior I will, however this was never foreseen to be done, if it breaks old behavior I am afraid you will be out of luck, but why be pessimistic. Just to explain the rationale, while we are happy to comply with GFM as much as humanly possible, our primary goal is the continued support to C.f. #249, which I would love to have, but the task is huge |
I have been giving this some thought. markdown = "a|b\n-|-\nd|e\n"
html = "<table>...\n"
messages = []
assert as_html(markdown, gfm_tables: true) == {:ok, html, messages} I hope that will be good for you. Hopefully GFM compatibility will advance and with issuing deprecations before adapting this behavior as default we might get to this as a default |
Earmark requires extra space around
|
, while GitHub doesn't:GitHub Render test:
works
doesn't work
The text was updated successfully, but these errors were encountered: