Switch from Hyperscan to a bundled version of Vectorscan #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions gives this:
ERROR: docker exporter does not currently support exporting manifest lists
Probably the `docker push` logic needs to be changed so it's not a
separate step.
This needs additional investigation.
This reverts commit 6bbafa1.
Much faster for this use!
bradlarsen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request switches from using the
rust-hyperscancrate to using a custom set of bindings based on those found inpyperscan. These new custom bindings statically link against a bundled version of Vectorscan that is built from source, instead of linking sometimes non-statically against Hyperscan.These new custom bindings appear in the
vectorscanandvectorscan-sysdirectories.These changes make it simpler to build Nosey Parker from source, especially on ARM systems, and make it feasible to distribute prebuilt binaries in future releases (#28).
Fixes #5.