Add temporary write result hardcoding #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HawkiesZA
approved these changes
Oct 17, 2024
rudigiesler
deleted the
feature/DELTA-1323/add-temporary-write-result-hardcoding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Turn, write_result doesn'y allow you to set the name to something dynamic, only the value.
This means that we cannot create result names in the way the DS team would like them to be able to do proper analysis on them.
We're working with the Turn team on this, but for now, we're hardcoding the name of the flow results, instead of pulling it from the CMS, so that the DS team is unblocked until we can get the permanent fix in place