-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TR Language and some code refactoring #497
Conversation
- BAD USB and BAD BLE now have their own separate menus. - Resolved conflict between CH9329 and BleKeyboard. - Refactored and cleaned up some parts of the code for improved readability and maintainability.
I dont really get the issue with other platforms, if any other contributor could help would be great. |
Works now on all platform but the section only has Bad USB (originally was in Other section). Tested on CYD. |
Types of Changes
|
Hey @9dl thanks for contributing! |
Yeah, the bowling ball was supposed to be a skull, haha. I'm not really great at designing icons, so it was a placeholder. As for Bad BLE, I ran into a lot of issues trying to combine it with Bad USB on other platforms. The keyboard libraries kept conflicting, and I couldn’t find a solid workaround. |
Types of Changes
|
@pr3y I changed everything back to normal. 👍 |
Awesome! looks good to me now, feel free to join our discord |
Proposed Changes
This pull request refactors and optimizes the interface based on issue #491. It introduces a new Bad Devices menu on the main page, which consolidates Bad USB and Bad BLE into a single section. The following changes are also made:
Resolved conflict between CH9329 and BleKeyboard.
Additionally, the code was refactored and cleaned up for improved readability and maintainability.
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
-/-