Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R3ck changes #252

Merged
merged 7 commits into from
Sep 10, 2024
Merged

R3ck changes #252

merged 7 commits into from
Sep 10, 2024

Conversation

rennancockles
Copy link
Collaborator

Refactor

  • remove rfid libs from project

Fix

  • add validation for timestamp in wardriving filename (still not perfect though)

Feature

  • add "Wigle Upload All" menu option to upload all csv files to wigle
  • auto delete wardriving files after uploading it to wigle
  • add config option to enable or disable boot sound (enabled by default)

@bmorcelli
Copy link
Collaborator

https://github.com/rennancockles/MFRC522-I2C/blob/main/MFRC522_I2C.cpp#L10

GitHub Workflows are case sensitive.

This Lib file is CAPS, and the include is lower case.. just change make the include match the file name (Caps and all) and it will work ;)

@eadmaster
Copy link
Contributor

add config option to enable or disable boot sound (enabled by default)

Instead of a setting for the boot sound only, i think it would be better to have a more generic "silent mode" setting, that prevents the _tone() and playAudioFile() functions from making any noise.
Other modules/script could use these functions to play notification sounds.

@pr3y pr3y merged commit d65127e into pr3y:main Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants