main menu refactor #230
Merged
main menu refactor #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennancockles
force-pushed
the
feat/main_menu
branch
from
a09046c to
f8937a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Refactor of main menu. Each menu is now a class and contains its own name, menu function and a draw function to draw its icon. With the proposed changes each menu item class is a separate module with everything it needs.
The main_menu file now contains a list of menu item classes and it's not needed to keep multiple lists with items in the same order like list os menu names and menu function call.
NOTE: this PR looks bigger than it is because it contains changes from PR #229
Types of Changes
Refactor
User-Facing Change
Nothing