-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix appveyor integration by not using cake for build #6958
Conversation
Validated at my fork. The validation of deployment is a bit out of date. It requires to deploy to a fake environment. |
Deployment proved: |
dd404f7
to
c51b6f4
Compare
Changing the tests directory organization should be suitable for another PR. |
No: currently android test will fail on loading beatmap resource. Since no one is actually using it, let's delay it. |
AppVeyor does't allow mixture of propertyset and command line. Enabling WarningAsError without incluencing normal build requires explicit specifying everything. |
I'm also not strongly against @smoogipoo thoughts? |
Or a condition in csproj to detect weather it's built by appveyor, similar to what we did for referencing native libs from framework. |
I think it’s fine as always on. We’ve already had a warning in osu.Game that we’ve ignored for months. |
Windows build for iOS provides warnings, and is skipped now via solution configuration. Once ppy/osu-framework#3044 get resolved, it can have managed side covered by Windows pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give this a shot
Fixes #6913 .
The key improvements: compiler and nuget warnings are populated, Xamarin projects are covered
I'm keeping in mind that making build configuration straightforward.
AppVeyor directly integrates to MSBuild. The configuration is quite simple.
Note that much more warnings are populated, including ones during restore and packing. It's very boring and hard to collection all them in cake.
InspectCode integrates very badly with the .NET Core world. It's strongly depending "desktop" MSBuild which is only accessible from Visual Studio Developer CLI, and supporting only Windows. Integrating it into the experience of VS will probably break command line on .NET Core. So I'm keeping the current progress with cake unchanged.
I also removed the "1 script to do what CI does at local", because:
dotnet format
.I've tried a lot at my local fork to make sure everything is working. Deployment is proved by the correct artifacts collected by AppVeyor. (https://ci.appveyor.com/project/huoyaoyuan/osu-deploy/builds/29081533/artifacts)