Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adjusting control point offset after undo/redo causing catastrophic failure #31109

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 13, 2024

Closes #31098.

Low effort fix because it was already half broken. The test was testing in isolation but in actual editor usage it wasn't working as expected.

…ic failure

Closes ppy#31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
@bdach bdach merged commit 573d709 into ppy:master Dec 16, 2024
10 checks passed
@peppy peppy deleted the fix-editor-timing-undo-redo branch December 22, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing timing point offset after undoing timing point change creates an empty duplicate
2 participants