Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lookups of hit circle slider pieces potentially using wrong source skin #31052

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix lookups of hit circle slider pieces potentially using wrong source skin #31052

merged 1 commit into from
Dec 10, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 10, 2024

Addresses #30927.

Using the test setup in that discussion thread:

Before After
2024-12-10 22 10 33@2x 2024-12-10 22 09 13@2x

smoogipoo
smoogipoo approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think there's much to review here, lgtm

@smoogipoo smoogipoo merged commit 86f86fa into ppy:master Dec 10, 2024
8 of 10 checks passed
@Joehuu Joehuu mentioned this pull request Dec 19, 2024
Closed
@peppy peppy deleted the fix-hitcircle-lookup-fallback branch December 22, 2024 06:26
@peppy peppy mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:skinning size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @smoogipoo