Fix occasional flash when quick exiting / retrying from player

[peppy]

The gist of the issue is that fadeOut was being called twice in the quick exit/retry scenarios, causing weirdness with transforms.

I've restructured things to ensure it's only called once.

[bdach]

How do I test that this does what it says? Do I need to?

[peppy]

How do I test that this does what it says? Do I need to?

If you just want to confirm that this fixes the double-fadeOut call you can place a breakpoint in fadeOut on master and notice that it's always hit twice (once with instant=true and once with instant=false).

You could also try adjusting the values of the fadeout to repro the flash I was seeing, but maybe not worth it and just trust that I can no longer reproduce it. May be single thread only.

[bdach]

Code seems fine now, that said, I'm gonna be a pain in the ass about this, and say that... this seems visually worse somehow?

master:

2024-11-14.15-21-16.mp4

this PR:

2024-11-14.15-19-39.mp4

Look at the playfield border specifically. It's doing this weird choppy fade now, rather than the smooth fade it is doing on master. I'm guessing that'll be caused by fadeOut() not getting called immediately in the two snipped call sites, and instead being shifted to On{Suspending,Exiting}().

[peppy]

That seems wrong. I'll re-check.

[bdach]

Seems ok now