Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify convertible hitobject parsing and add IHasLegacyHitObjectType #30578

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Simplify convertible hitobject parsing and add IHasLegacyHitObjectType #30578

merged 5 commits into from
Nov 14, 2024

Commits on Nov 11, 2024

  1. Merge implementations of ConvertHitObjectParser 

    Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
    @smoogipoo
    smoogipoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e1d93a7 View commit details
    Browse the repository at this point in the history

  2. Add IHasLegacyHitObjectType to ConvertHitObject

    @smoogipoo
    smoogipoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7206e97 View commit details
    Browse the repository at this point in the history

  3. Remove unused params

    @smoogipoo
    smoogipoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8c68db0 View commit details
    Browse the repository at this point in the history

  4. Update test

    @smoogipoo
    smoogipoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    06380f9 View commit details
    Browse the repository at this point in the history

  5. Fix the other test class too

    @smoogipoo
    smoogipoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1c3a30a View commit details
    Browse the repository at this point in the history