Fix break overlay grades not using localised string #30572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the final goal should be to show the rank letter, but this seems more correct for now. |
peppy
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, this looks weird to me in this context for some reason (having silver in the grade name) but it matches and is consistent with the beatmap listing filter now.
Discord convo ref: https://discord.com/channels/188630481301012481/1097318920991559880/1304965291784142858
Wiki ref: https://osu.ppy.sh/wiki/en/Gameplay/Grade
The "+" is only ever mentioned in https://osu.ppy.sh/wiki/en/History_of_osu%21/2018#february and russian localisation (probably some old translation that never got updated).
Edit: could probably just play with colors instead for plain text like this?