Clamp estimateImproperlyFollowedDifficultSliders for lazer scores

[Finadoggie]

Fixes instances of maps giving too much pp if their slider count on the servers is less than their actual slider count (or any other scenario where a negative number of dropped slider ends is feasible)

[smoogipoo]

Sure, but isn't this hiding the issue?

[Finadoggie]

I guess it is. Is that a bad thing?

[Rekunan]

isn't this hiding the issue?

It's the same for stable scores:

osu/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs

Line 177 in 8bd65d9

estimateImproperlyFollowedDifficultSliders = Math.Clamp(Math.Min(maximumPossibleDroppedSliders, attributes.MaxCombo - scoreMaxCombo), 0, estimateDifficultSliders);

And existed before #27691 was merged:

osu/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs

Line 125 in 970e45f

double estimateSliderEndsDropped = Math.Clamp(Math.Min(countOk + countMeh + countMiss, attributes.MaxCombo - scoreMaxCombo), 0, estimateDifficultSliders);

So if there is an issue with this change, then we should probably remove the clamping for stable scores (and maybe reconsider other/similar occurrences in diffcalc).

[smoogipoo]

It's the same for stable scores:

As I read it, that's because it's an estimation where the lazer path is supposed to be more accurate. But sure.

[smoogipoo]

Approved but blocked on #30566 😴

[smoogipoo]

Sorry, I'm going to use this PR as a bit of a testbed.

[smoogipoo]

!diffcalc

[github-actions]

Target: #30544
Spreadsheet: https://docs.google.com/spreadsheets/d/1zcV1W19EW9UVQWaUbg9WShrNF44kG8-vhzcTVDVsd6c/edit