Globalise CountDifficultStrains within StrainSkill
#30534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunyoku
reviewed
Nov 7, 2024
stanriders
reviewed
Nov 7, 2024
tsunyoku
suggested changes
Nov 7, 2024
|
I think we're better off renaming the attributes in a separate PR just for sanity's sake. |
tsunyoku
approved these changes
Nov 7, 2024
|
!diffcalc |
smoogipoo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
CountDifficultStrainsmethod to be accessible and usable by all rulesets;CountDifficultStrainsinto StrainSkillThis globalisation is intended primarily for use within osu!taiko future changes but also to give other rulesets the opportunity to utilise the concept in their own calculations.
While the weighting constants were designed for osu! to give nice values, values look fine - specifically osu!taiko.