-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breathing room to seek back between control points in editor #30328
Conversation
Not anything you need to concern yourself with. That problem is already fixed in master. |
Stable logic for this is if (AudioEngine.ActiveInheritedTimingPointIndex < 0) return;
if (AudioEngine.Time - AudioEngine.ControlPoints[AudioEngine.ActiveInheritedTimingPointIndex].Offset > 1000)
{
AudioEngine.SeekTo((int)AudioEngine.ControlPoints[AudioEngine.ActiveInheritedTimingPointIndex].Offset);
return;
}
if (AudioEngine.ActiveInheritedTimingPointIndex == 0)
return;
AudioEngine.SeekTo((int)AudioEngine.ControlPoints[AudioEngine.ActiveInheritedTimingPointIndex - 1].Offset); In particular note:
(Side note but the stable implementation is bugged - if you have a non-inherited point and inherited point on the same timestamp, e.g. a "yellow line", you won't be able to seek back beyond it. Not relevant in this context anyhow.) @peppy obligatory summon for UX opinion on desired behaviour |
I really do question 8 commits for 10 LoC changes and it's still failing basic formatting requirements, but let's overlook that for now 🙈 |
osu.Game/Screens/Edit/Editor.cs
Outdated
IAdjustableClock adjustableClock = clock; | ||
seekMargin = 450 * adjustableClock.Rate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think rate needs to be accounted for? Especially if we increase this to 1 second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine to leave it, whatever works.
I've given up on even remarking on that sort of thing at this point because it helps nothing and only looks snarky. |
I guess in an attempt to make it non-snarky, @TaterToes consider not PRing until you're done with making changes, then squash your changes down to less commits if you want to seem more competent 😅 |
closes #28885 (and #30070)
gives 450 ms to seek back after last control point in editor.