Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete dialogs having generic "Caution" header text #30133

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 7, 2024

osu! 2024-10-07 at 07 48 38

Regressed in #28363.

Closes #30071.
Supersedes #30102 which fell short.

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Oct 7, 2024
@bdach bdach self-requested a review October 7, 2024 07:49
@bdach
Copy link
Collaborator

bdach commented Oct 7, 2024

I suppose this works? The copy is still maybe a touch generic, but it's probably good enough (unquestionably better than previous)...

@bdach bdach merged commit 958ee8a into ppy:master Oct 7, 2024
9 checks passed
@peppy peppy deleted the delete-header-text branch October 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M type:cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion dialogs all have broken messaging
2 participants