Add daily challenge animation to daily challenge notification #29770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ianlucht
changed the title
bdach
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
I am choosing to ignore the code duplication, because it's non-trivial duplication of trivial logic (see PerformFromScreen() usage that isn't there in the other place) and there are only 2 places that do this for now. If this changes/happens again and/or there are more places that do this in the future then splitting a helper should be reconsidered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added if conditional similar to main menu if conditional to activate DailyChallengeNotification if the user opens the Daily Challenge from the notification. Potentially excessively verbose, however this is future proof in the scenario that the Daily challenge is opened from the menu and then opened again from the notification menu.
resolves #29747