Rework kiai handling in SummaryTimeline
#29667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #29389
Closes #20122
Honestly I found it very uncomfortable to work with the current implementation, it's very hard to keep track of what's being drawn and at which stage things being updated, so I just used
BreakPartas a reference and decoupled kiai sections fromEffectPointVisualisationaltogether. Result is super simple to read and understand what's going on.Potential downside is that everything is being recalculated when
ControlPointsChangedaction being invoked (not only affected points), but this happens only once per action which is still way better than what we have currently.