Handle new naming inspections on certain enums #28051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
May 1, 2024
osu.Desktop/NVAPI.cs
Outdated
| @@ -489,6 +489,7 @@ internal struct NvApplication | |||
| public static uint Stride => (uint)Marshal.SizeOf(typeof(NvApplication)) | (2 << 16); | |||
| } | |||
|
|
|||
| // ReSharper disable InconsistentNaming | |||
There was a problem hiding this comment.
Can we use [SuppressMessage("ReSharper", "InconsistentNaming")] instead? I really dislike the disable/restore pairs.
If that's not feasible, I'd just disable at a file level
peppy
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All enum fields by default should follow the pascal-case naming style, unless there's a specific reason not to (e.g. p/invoke).
If an enum field is named after a specific abbreviation, said abbreviation should be added to rider configuration in this manner:
There are existing fields in general that can benefit from the abbreviation feature (e.g.
HpDrain), but I've abstained from including them here.