-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove estimations where score data is available for osu! difficulty calculations #27691
Merged
Merged
Changes from 27 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
941c048
Make length bonus account for sliders, use proper misscount for classic
Finadoggie 4db6f28
Use actual sliderends dropped instead of estimating
Finadoggie 3dafdc0
Revert "Make length bonus account for sliders, use proper misscount f…
Finadoggie 8408455
Use miss count for effective miss count
Finadoggie 12afa8d
Merge pull request #1 from Finadoggie/miss-count-fix
Finadoggie eb30b4a
Merge branch 'estimation-removal' into dropped-tail-fix
Finadoggie c9e3c10
Merge pull request #2 from Finadoggie/dropped-tail-fix
Finadoggie b0d20e6
Update OsuPerformanceCalculator.cs
Finadoggie 6fe478c
Add slider ticks and reverse arrows to effective misscount
Finadoggie 4f5f0e5
Merge branch 'master' into estimation-removal
Finadoggie 58bc184
Use sliderend data for all non-legacy scores
Finadoggie c24f99e
Merge branch 'estimation-removal' of https://github.com/Finadoggie/os…
Finadoggie 2dd4903
Cap Buzz Slider Related Misses
Finadoggie dd17c89
removed large tick misses from effectivemisscount
Finadoggie ca24601
Add bool useSliderHead
Finadoggie 77814ec
Fix getting slider head drops
Finadoggie 759a826
Clamp estimatedSliderEndsDrop
Finadoggie 4a7b813
Re-add bool useSliderHead
Finadoggie d1dcac0
fix code formatting
Finadoggie 4fe55d4
Renamed useSliderHead to useClassicSlider (and refactored code accord…
Finadoggie 1f55c14
merged givi's accuracy changes
Finadoggie 6c9e906
Revert "merged givi's accuracy changes"
Finadoggie 8dea601
Merge branch 'master' into estimation-removal
Finadoggie 44c9425
Merge branch 'ppy:master' into estimation-removal
Finadoggie 3d7f4ae
Merge branch 'ppy:master' into estimation-removal
Finadoggie b921424
Update to use variable usingClassicSliderAccuracy
Finadoggie 3b517e0
Convert estimateSliderEndsDropped assignment into '?:' expression
Finadoggie 3ac6a9f
Join variable assignments with declarations
Finadoggie 29b1697
consolidated if statements for getting effectiveMissCount and countSl…
Finadoggie 88af578
only assign countLargeTickMiss for slider accuracy scores
Finadoggie 5192599
remove score debugging code I accidentally left in
Finadoggie 6bcfed8
Revert "remove score debugging code I accidentally left in"
Finadoggie 1337b7e
use LargeTickHit instead of LargeTickMiss
Finadoggie 6d4cb60
Revert "use LargeTickHit instead of LargeTickMiss"
Finadoggie 31e0853
add large tick misses back into effectivemisscount
Finadoggie e31e10d
merge effectivemisscount functions
Finadoggie 3778246
Addressed code quality concerns
Finadoggie 5907c2a
Only clamp estimated miss count with relevant statistics
Finadoggie 98800fe
Fix variables being used before being assigned
Finadoggie bcb9970
Refactor and add comments
stanriders acf282d
Fix effectiveMissCount being calculated wrong
stanriders File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since slider-related code uses the term "tail" (and the hit result does too), I'd suggest renaming this to
countSliderTailMiss
orcountSliderTailsDropped
. I'd prefer to consider "miss" the opposite of hit even for slider tails but calling them "dropped" is arguable