Fix tournament bracket parsing's ruleset refetch logic not working correctly #17574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, tournament client may have written incorrect `OnlineID` values. We wanted to use `ShortName` to re-fetch the ruleset. This test ensures this flow is working correctly.
…rrectly Due to equality being based on `ShortName`, it was feasible that the re-fetch exited early (in bindable shortcutting logic) causing the ruleset's `OnlineID` to remain `-1` or something equally wrong. Resolves issue pointed out at ppy#17538 (reply in thread).
peppy
commented
Mar 31, 2022
| // we don't want to show the menu cursor as it would appear on stream output. | ||
| MenuCursorContainer.Cursor.Alpha = 0; | ||
|
|
||
| base.LoadComplete(); | ||
|
|
||
| Task.Run(readBracket); |
There was a problem hiding this comment.
This was moved to LoadComplete to allow the new test to exist (I need code to run before this, and it wasn't easy to make happen as long as it was in the Game's async load implementation.
Doesn't seem to have any adverse effects.
smoogipoo
approved these changes
Mar 31, 2022
I guess there's no better way to handle this then? Was hoping you'd have something in mind. Does make you wonder about the equality implementation, though.. |
|
I have no suggestions, just had to do a double take at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to equality being based on
ShortName, it was feasible that the re-fetch exited early (in bindable shortcutting logic) causing the ruleset'sOnlineIDto remain-1or something equally wrong.Resolves issue pointed out at #17538 (reply in thread).