Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo #14918

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 1, 2021

This converts read-only usages of BeatmapDifficulty to use the new interface type. Not a final goal but a stepping stone towards the end picture.

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Oct 6, 2021
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay otherwise. Unfortunate breaking changes...

osu.Game/osu.Game.csproj Outdated Show resolved Hide resolved
Co-authored-by: Dan Balasescu <[email protected]>
@peppy
Copy link
Member Author

peppy commented Oct 6, 2021

I think we're going to have to deal with breaking changes to move forward efficiently for now. Luckily ruleset creators seem on top of that.

@smoogipoo smoogipoo merged commit 5eb4210 into ppy:master Oct 6, 2021
@peppy peppy deleted the beatmap-difficulty-more-interface-usage branch October 6, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants