Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash after clicking to watch gameplay replay #28216

Closed
alittlehuaji opened this issue May 19, 2024 · 3 comments · Fixed by #28262
Closed

Crash after clicking to watch gameplay replay #28216

alittlehuaji opened this issue May 19, 2024 · 3 comments · Fixed by #28262
Assignees
@bdach
Labels
area:replay type:reliability

Comments

@alittlehuaji
Copy link

alittlehuaji commented May 19, 2024 •
edited
Loading

Type

Crash to desktop

Bug description

General steps to reproduce this problem:
Start osu and go to the homepage --> click play --> click solo --> select a beatmap --> click any result on the left ranking list --> click download replay --> (after downloading is complete) click watch replay --> Game crashes

I'm not sure if this is my problem 🤔 so I ask you guys to look into this error. If it’s a bug, please fix it😊

I'm not very good at communicating in English, so please forgive me if there are any grammatical errors!

Screenshots or videos

bandicam.2024-05-20.00-29-44-477.mp4

Version

2024.519.1-lazer

Logs

compressed-logs.zip
@bdach
Copy link
Collaborator

bdach commented May 20, 2024

Something is very wrong here.

2024-05-19 15:58:17 [verbose]: ⚠️ Downloading TheShadowOfDark playing HO-KAGO TEA TIME - Kira Kira Days (Cut Ver.) (Sotarks) [Kowari's Hard]
2024-05-19 15:58:19 [verbose]: ⚠️ Imported TheShadowOfDark playing HO-KAGO TEA TIME - Kira Kira Days (Cut Ver.) (Sotarks) [Kowari's Hard]! Click to view.
2024-05-19 15:58:19 [verbose]: Beginning PresentScore with score TheShadowOfDark playing HO-KAGO TEA TIME - Kira Kira Days (Cut Ver.) (Sotarks) [Kowari's Hard]
2024-05-19 15:58:19 [verbose]: 📺 OsuScreenStack#457(depth:4) exit from SoloResultsScreen#625
2024-05-19 15:58:19 [verbose]: 📺 OsuScreenStack#457(depth:4) resume to PlaySongSelect#114
2024-05-19 15:58:19 [verbose]: 📺 BackgroundScreenStack#368(depth:1) exit from BackgroundScreenBeatmap#387
2024-05-19 15:58:19 [verbose]: 📺 BackgroundScreenStack#368(depth:1) resume to BackgroundScreenDefault#234
2024-05-19 15:58:19 [verbose]: 📺 OsuScreenStack#457(depth:3) exit from PlaySongSelect#114
2024-05-19 15:58:19 [verbose]: 📺 OsuScreenStack#457(depth:3) resume to MainMenu#487
2024-05-19 15:58:19 [verbose]: decoupled ruleset transferred ("" -> "osu!")
2024-05-19 15:58:19 [verbose]: 🌅 Global background change queued
2024-05-19 15:58:19 [verbose]: 🌅 Global background change queued
2024-05-19 15:58:20 [verbose]: ButtonSystem's state changed from EnteringMode to TopLevel
2024-05-19 15:58:20 [verbose]: PresentScore updating beatmap (Sakura Miko - Kyun Kyun MIKO Kyun kyun <3 (Left) [Normal]) and ruleset (sentakki) to match score
2024-05-19 15:58:20 [verbose]: Game-wide working beatmap updated to Sakura Miko - Kyun Kyun MIKO Kyun kyun <3 (Left) [Normal]
2024-05-19 15:58:20 [verbose]: 📺 OsuScreenStack#457(depth:3) suspended MainMenu#487 (waiting on ReplayPlayerLoader#400)
2024-05-19 15:58:20 [verbose]: ButtonSystem's state changed from TopLevel to EnteringMode
2024-05-19 15:58:20 [verbose]: 📺 OsuScreenStack#457(depth:4) loading ReplayPlayerLoader#400
2024-05-19 15:58:20 [verbose]: 🌅 Global background change queued
2024-05-19 15:58:20 [verbose]: 📺 OsuScreenStack#457(depth:4) entered ReplayPlayerLoader#400
2024-05-19 15:58:20 [error]: An unhandled error has occurred.
2024-05-19 15:58:20 [error]: System.InvalidOperationException: Can not set value to "osu!" as bindable is disabled.
2024-05-19 15:58:20 [error]: at osu.Framework.Bindables.Bindable`1.set_Value(T value)
2024-05-19 15:58:20 [error]: at osu.Game.OsuGameBase.<>

Why is this attempting to show a sentakki score of all things?

@HappyMC-Dev can you attach client.realm for inspection?

@bdach bdach added the missing details Can't move forward without more details from the reporter label May 20, 2024
@alittlehuaji
Copy link
Author

osu.zip
Are these two files?

@bdach
Copy link
Collaborator

bdach commented May 20, 2024

Yes, thanks, that explains it.

@bdach bdach self-assigned this May 20, 2024
@bdach bdach removed the missing details Can't move forward without more details from the reporter label May 20, 2024
bdach added a commit to bdach/osu that referenced this issue May 20, 2024
@bdach
Do not attempt to match score by equality of hash if it's empty
94b14f6 
Closes ppy#28216.

The affected user's database contained six sentakki scores with an empty
hash. When an online score is being imported, an online model (which
does not have a hash) will be transmogrified into a `ScoreInfo` with
an empty hash, which would end up accidentally matching those scores
and basically breaking everything at that point.

To fix, avoid attempting to match anything on empty hash. This does not
break online score matching because for those cases the actual online ID
of the score will be used.
bdach added a commit to bdach/osu that referenced this issue May 20, 2024
@bdach
Do not attempt to match score by equality of hash if it's empty
ed498f6 
Closes ppy#28216.

The affected user's database contained six sentakki scores with an empty
hash. When an online score is being imported, an online model (which
does not have a hash) will be transmogrified into a `ScoreInfo` with
an empty hash, which would end up accidentally matching those scores
and basically breaking everything at that point.

To fix, avoid attempting to match anything on empty hash. This does not
break online score matching because for those cases the actual online ID
of the score will be used.
This was referenced May 20, 2024
Merged
Closed
TextAdventurer12 pushed a commit to TextAdventurer12/osu that referenced this issue Jul 6, 2024
@bdach @TextAdventurer12
Do not attempt to match score by equality of hash if it's empty
fbde07f 
Closes ppy#28216.

The affected user's database contained six sentakki scores with an empty
hash. When an online score is being imported, an online model (which
does not have a hash) will be transmogrified into a `ScoreInfo` with
an empty hash, which would end up accidentally matching those scores
and basically breaking everything at that point.

To fix, avoid attempting to match anything on empty hash. This does not
break online score matching because for those cases the actual online ID
of the score will be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:replay type:reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not attempt to match score by equality of empty hash when presenting it bdach/osu
2 participants
@bdach @alittlehuaji